Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon rule spacing in function/method calls #1389

Closed
kmikael opened this issue Mar 24, 2017 · 5 comments
Closed

Colon rule spacing in function/method calls #1389

kmikael opened this issue Mar 24, 2017 · 5 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@kmikael
Copy link

kmikael commented Mar 24, 2017

The colon rule doesn't find correct spacing in function calls for me, for example:

object.method(x:5, y:"string")

should be

object.method(x: 5, y: "string")

Is this by design? I couldn't find a configuration to make this work.

@marcelofabri
Copy link
Collaborator

I think this is not currently supported, based on the tests.

Let's keep it open to track as an enhancement.

@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Apr 7, 2017
@kmikael
Copy link
Author

kmikael commented Apr 8, 2017

There is this case as well that does not work yet:

  • [class|struct|enum|extension] X: Y {

I think there are a few more but I can't remember them now. I will post them if I do.

@keith
Copy link
Collaborator

keith commented Apr 14, 2017

FWIW I think this is probably about the same case as this not erroring:

func foo(bar: [String : String]) {}

@serges147
Copy link
Contributor

I'm not sure is this cause but in 0.23.1 "warning: Colon Violation" rule is broken. I've got hundreds of such violations in 0.23.1, but zero at 0.22.0

@jpsim
Copy link
Collaborator

jpsim commented Oct 21, 2017

Please file a new issue, filling out the issue template. It’s hard to help without more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

5 participants