Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to function calls on colon rule #1839

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Add support to function calls on colon rule #1839

merged 2 commits into from
Sep 14, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1389

@jpsim
Copy link
Collaborator

jpsim commented Sep 13, 2017

Can you add the snippet from #1389 (comment) to the tests?

@marcelofabri
Copy link
Collaborator Author

@SwiftLintBot
Copy link

365 Warnings
⚠️ This PR introduced a violation in Aerial: /Users/distiller/SwiftLint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:224:67: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/SwiftLint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:296:67: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/SwiftLint/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:385:23: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/SwiftLint/osscheck/Alamofire/Package.swift:27:54: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Account/FxAClient10.swift:145:36: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Account/FxAState.swift:50:36: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Account/FxAState.swift:58:46: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift:266:68: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BackForwardTableViewCell.swift:44:41: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BackForwardTableViewCell.swift:143:33: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/ButtonToast.swift:88:69: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/QRCodeViewController.swift:88:121: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/QRCodeViewController.swift:88:172: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/QRCodeViewController.swift:88:207: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ActivityStreamPanel.swift:527:67: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ActivityStreamPanel.swift:666:46: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/HomePanelViewController.swift:56:26: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Intro/IntroViewController.swift:41:107: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/OldStrings.swift:56:48: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1479:93: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1554:86: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1574:88: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1574:98: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Browser/BrowserViewController.swift:1574:107: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:25:57: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:25:68: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:25:79: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:25:88: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/AdvanceAccountSettingViewController.swift:64:40: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/AppSettingsTableViewController.swift:118:66: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/FxAContentViewController.swift:80:51: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/UIConstants.swift:72:43: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/UIConstants.swift:72:57: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/UIConstants.swift:72:71: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/UIConstants.swift:72:86: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/ChevronView.swift:69:133: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/ChevronView.swift:71:137: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/ChevronView.swift:73:117: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/ChevronView.swift:75:141: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Widgets/PhotonActionSheet.swift:77:85: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Strings.swift:390:137: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:21:48: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:21:61: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:21:73: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:21:86: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/SendTo/ClientPickerViewController.swift:57:19: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:57:47: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:57:60: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:57:72: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/ShareTo/ShareViewController.swift:57:85: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Shared/Extensions/UIColorExtensions.swift:20:16: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Shared/Extensions/UIColorExtensions.swift:22:17: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Shared/UserAgent.swift:78:73: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Shared/UserAgent.swift:110:92: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Shared/UserAgent.swift:119:88: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Sync/StorageClient.swift:733:48: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:11:31: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:11:42: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:11:52: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:11:63: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:12:31: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:12:42: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:12:52: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:12:63: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:13:31: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:13:42: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:13:52: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/UIColorTests.swift:13:63: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/DiscoveryExpandableRowCellViewModel.swift:51:24: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ProjectActivityBackingCellViewModel.swift:192:22: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ProjectActivityBackingCellViewModelTests.swift:126:49: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/SwiftLint/osscheck/Kickstarter/Library/ViewModels/ProjectPamphletContentViewModel.swift:107:62: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Moya: /Users/distiller/SwiftLint/osscheck/Moya/Sources/Moya/Response.swift:107:61: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Moya: /Users/distiller/SwiftLint/osscheck/Moya/Tests/TestHelpers.swift:201:68: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Moya: /Users/distiller/SwiftLint/osscheck/Moya/Tests/TestHelpers.swift:201:68: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Sources/Nimble/Matchers/BeLessThanOrEqual.swift:36:42: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Helpers/utils.swift:91:31: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Helpers/utils.swift:91:40: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAKindOfTest.swift:70:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAKindOfTest.swift:81:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAKindOfTest.swift:84:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAnInstanceOfTest.swift:21:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAnInstanceOfTest.swift:58:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAnInstanceOfTest.swift:61:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeAnInstanceOfTest.swift:61:83: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:17:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:18:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:18:75: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:20:59: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:42:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:43:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanOrEqualToTest.swift:43:52: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:17:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:19:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:21:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:21:69: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:39:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:39:51: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:41:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeGreaterThanTest.swift:43:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeCloseToTest.swift:43:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeCloseToTest.swift:44:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeCloseToTest.swift:44:64: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeCloseToTest.swift:45:48: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeCloseToTest.swift:48:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:23:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:28:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:29:34: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:48:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:48:53: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeIdenticalToTest.swift:54:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanOrEqualToTest.swift:18:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanOrEqualToTest.swift:19:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanOrEqualToTest.swift:21:56: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanOrEqualToTest.swift:22:59: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanTest.swift:17:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ This PR introduced a violation in Nimble: /Users/distiller/SwiftLint/osscheck/Nimble/Tests/NimbleTests/Matchers/BeLessThanTest.swift:18:30: warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️ Danger found 365 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 117.
12 Messages
📖 Linting Aerial with this PR took 0.42s vs 0.37s on master (13% slower)
📖 Linting Alamofire with this PR took 3.05s vs 2.91s on master (4% slower)
📖 Linting Firefox with this PR took 12.34s vs 11.93s on master (3% slower)
📖 Linting Kickstarter with this PR took 19.32s vs 18.49s on master (4% slower)
📖 Linting Moya with this PR took 1.43s vs 1.32s on master (8% slower)
📖 Linting Nimble with this PR took 1.7s vs 1.64s on master (3% slower)
📖 Linting Quick with this PR took 0.53s vs 0.52s on master (1% slower)
📖 Linting Realm with this PR took 2.8s vs 2.63s on master (6% slower)
📖 Linting SourceKitten with this PR took 0.98s vs 0.95s on master (3% slower)
📖 Linting Sourcery with this PR took 4.41s vs 4.12s on master (7% slower)
📖 Linting Swift with this PR took 13.44s vs 12.92s on master (4% slower)
📖 Linting WordPress with this PR took 11.71s vs 11.21s on master (4% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1839 into master will decrease coverage by 0.01%.
The diff coverage is 88.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
- Coverage   88.82%   88.81%   -0.02%     
==========================================
  Files         231      234       +3     
  Lines       11339    11377      +38     
==========================================
+ Hits        10072    10104      +32     
- Misses       1267     1273       +6
Impacted Files Coverage Δ
Source/swiftlint/Commands/AutoCorrectCommand.swift 0% <0%> (ø) ⬆️
...Tests/CyclomaticComplexityConfigurationTests.swift 100% <100%> (ø) ⬆️
...wiftLintFramework/Rules/ColonRule+Dictionary.swift 82.97% <82.97%> (ø)
Source/SwiftLintFramework/Rules/ColonRule.swift 93.75% <83.33%> (+1.34%) ⬆️
...ftLintFramework/Rules/ColonRule+FunctionCall.swift 87.09% <87.09%> (ø)
...urce/SwiftLintFramework/Rules/ColonRule+Type.swift 96.29% <96.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ff336...f58ade8. Read the comment docs.

@marcelofabri
Copy link
Collaborator Author

I've ran this locally and the performance penalty was lower:

Message: Linting Aerial with this PR took 0.32s vs 0.27s on master (18% slower)
Message: Linting Alamofire with this PR took 1.8s vs 1.79s on master (0% slower)
Message: Linting Firefox with this PR took 7.2s vs 7.02s on master (2% slower)
Message: Linting Kickstarter with this PR took 11.43s vs 11.26s on master (1% slower)
Message: Linting Moya with this PR took 0.87s vs 0.85s on master (2% slower)
Message: Linting Nimble with this PR took 1.05s vs 1.03s on master (1% slower)
Message: Linting Quick with this PR took 0.34s vs 0.33s on master (3% slower)
Message: Linting Realm with this PR took 1.64s vs 1.62s on master (1% slower)
Message: Linting SourceKitten with this PR took 0.63s vs 0.61s on master (3% slower)
Message: Linting Sourcery with this PR took 2.64s vs 2.59s on master (1% slower)
Message: Linting Swift with this PR took 7.61s vs 7.55s on master (0% slower)
Message: Linting WordPress with this PR took 6.74s vs 6.48s on master (4% slower)

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a light review, but looks awesome!

@marcelofabri marcelofabri merged commit 038af4e into realm:master Sep 14, 2017
@marcelofabri
Copy link
Collaborator Author

🎉

@marcelofabri marcelofabri deleted the function-call-colon branch September 14, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants