-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to function calls on colon
rule
#1839
Conversation
Can you add the snippet from #1389 (comment) to the tests? |
That was already done on the previous PR: https://github.com/marcelofabri/SwiftLint/blob/f58ade89bb1aa2874a6e5a1cf854f0703df89518/Source/SwiftLintFramework/Rules/ColonRule.swift#L52 |
Codecov Report
@@ Coverage Diff @@
## master #1839 +/- ##
==========================================
- Coverage 88.82% 88.81% -0.02%
==========================================
Files 231 234 +3
Lines 11339 11377 +38
==========================================
+ Hits 10072 10104 +32
- Misses 1267 1273 +6
Continue to review full report at Codecov.
|
I've ran this locally and the performance penalty was lower:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only did a light review, but looks awesome!
🎉 |
Fixes #1389