New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical_parameter_alignment rule generates incorrect warning for nested parentheses #1488

Closed
garie opened this Issue May 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@garie

garie commented May 3, 2017

Version 0.18.1

This code generates a warning:

    static func getAdditionalInfoTextField(data: (size: CGSize,
                                                  identifier: String,
                                                  placeHolder: NSAttributedString,
                                                  padding: CGRect,
                                                  borderColor: CGColor,
                                                  borderWidth: CGFloat,
                                                  required: Bool)) -> UITextField {

This code does not generate a warning:

    static func getAdditionalInfoTextField(data: (size: CGSize,
                                           identifier: String,
                                           placeHolder: NSAttributedString,
                                           padding: CGRect,
                                           borderColor: CGColor,
                                           borderWidth: CGFloat,
                                           required: Bool)) -> UITextField {

@garie garie changed the title from `vertical_parameter_alignment` generates incorrect warning for nested parentheses to vertical_parameter_alignment rule generates incorrect warning for nested parentheses May 3, 2017

@marcelofabri marcelofabri added the bug label May 4, 2017

marcelofabri added a commit to marcelofabri/SwiftLint that referenced this issue Jul 30, 2017

Add test and changelog entry for realm#1488
realm#1488 was fixed in realm#1726.

This adds a test to make sure we don’t introduce regressions in the future and also adds a changelog entry.
@marcelofabri

This comment has been minimized.

Show comment
Hide comment
@marcelofabri

marcelofabri Jul 30, 2017

Collaborator

Fixed by @jpsim in #1726 🎉

Collaborator

marcelofabri commented Jul 30, 2017

Fixed by @jpsim in #1726 🎉

marcelofabri added a commit that referenced this issue Jul 30, 2017

Merge pull request #1727 from marcelofabri/fix-1488
Add test and changelog entry for #1488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment