Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests when linting with Swift 4.1 #2021

Closed
2 tasks done
marcelofabri opened this issue Jan 25, 2018 · 1 comment
Closed
2 tasks done

Fix unit tests when linting with Swift 4.1 #2021

marcelofabri opened this issue Jan 25, 2018 · 1 comment
Labels
bug

Comments

@marcelofabri
Copy link
Collaborator

New Issue Checklist

Bug Report

Even after #2020, some unit tests are failing when a Swift 4.1 toolchain is used.

captura de tela 2018-01-25 as 09 50 00

Executed 345 tests, with 1126 failures (0 unexpected) in 58.262 (58.485) seconds

Environment

  • SwiftLint version (run swiftlint version to be sure)? master
  • Installation method used (Homebrew, CocoaPods, building from source, etc)? source
  • Which Xcode version are you using (check xcode-select -p)? 9.2 with swift-4.1-DEVELOPMENT-SNAPSHOT-2018-01-23-a.xctoolchain selected
This was referenced Jan 26, 2018
Merged
Merged
@marcelofabri
Copy link
Collaborator Author

testDetectSwiftVersion is only failing because I'm compiling with Swift 4.0.3, but running with a 4.1 toolchain. It shouldn't happen after we start using Xcode 9.3.

@marcelofabri marcelofabri mentioned this issue Jan 27, 2018
Merged
@marcelofabri marcelofabri mentioned this issue Feb 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcelofabri