Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type_name rule violations to be positioned on the type name #2023

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Improve type_name rule violations to be positioned on the type name #2023

merged 1 commit into from
Jan 27, 2018

Conversation

marcelofabri
Copy link
Collaborator

Part of #2021

This unifies where violations are reported in type_name rule. Previously typealias and associatedtype were reported on nameOffset, but all the other types were reported on offset.

This will be useful to fix this rule when using Swift 4.1, as we'll no longer need to have the typealias and associatedtype validation using regexes.

I've decided to open a PR just for this because it'll cause a lot of noise in oss-check.

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 26, 2018

252 Warnings
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/MultipartFormDataTests.swift:435:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'MultipartFormDataWriteEncodedDataToDiskTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/SessionManagerTests.swift:776:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'SessionManagerConfigurationHeadersTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/TLSEvaluationTests.swift:66:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'TLSEvaluationExpiredLeafCertificateTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:224:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyExplorationBasicX509PolicyValidationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:285:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyExplorationSSLPolicyValidationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:415:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyPerformDefaultEvaluationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:582:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyPerformRevokedEvaluationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1530:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyDisableEvaluationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1560:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyCustomEvaluationTestCase' (type_name)
⚠️ This PR introduced a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1594:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyCertificatesInBundleTestCase' (type_name)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchLoader.swift:22:7: error: Type Name Violation: Type name should only contain alphanumeric characters: '_SearchLoader' (type_name)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RecentlyClosedTabsPanel.swift:81:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'RecentlyClosedTabsPanelSiteTableViewController' (type_name)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/ToggleButton.swift:7:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'UX' (type_name)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Push/PushConfiguration.swift:66:15: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FirefoxNightlyEnterprisePushConfiguration' (type_name)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:248:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'EditableBufferBookmarksSQLiteBookmarksModelFactory' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackerDashboardProjectsViewControllerTests.swift:8:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'BackerDashboardProjectsViewControllerTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewControllerTests.swift:8:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DiscoveryNavigationHeaderViewControllerTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectPamphletContentViewControllerTests.swift:10:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectPamphletContentViewControllerTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Activity.MemberDataLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ActivityLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CheckoutEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CommentLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/BackingLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CreatePledgeEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/MockService.swift:1186:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ConfigLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FriendStatsEnvelope.StatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:21:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:30:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:39:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:21:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:30:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FriendStatsEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/GraphCategoriesEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ItemLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/LocationLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/GraphCategoryLenses.swift:6:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/MessageLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.DatesLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/MessageThreadLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryParamsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.MemberDataLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.PersonalizationLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.PhotoLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.VideoLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.StatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectNotification.ProjectLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectNotificationLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.CumulativeStatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.FundingDateStatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.RewardDistributionLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.ReferrerStatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.VideoStatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Reward.ShippingLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/RewardItemLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:154:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:163:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:56:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:102:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:111:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:125:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:139:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:153:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ShippingRulesEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ShippingRuleLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/StarEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/SubmitApplePayEnvelopeLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/SurveyResponseLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/RewardLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.AvatarLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:23:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:42:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.StatsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.NotificationsLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UserLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/templates/CategoryTemplates.swift:3:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ID' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ExpandableRow.swift:9:17: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/Format.swift:391:20: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ProjectActivityData.swift:9:17: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/SelectableRow.swift:8:17: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/String+Base64Tests.swift:4:7: error: Type Name Violation: Type name should only contain alphanumeric characters: 'String_Base64Tests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/Koala/Koala.swift:2096:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardProjectsDrawerCellViewModelTests.swift:9:24: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardProjectsDrawerCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardReferrerRowStackViewViewModelTests.swift:10:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardReferrersRowStackViewViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardRewardRowStackViewViewModelTests.swift:10:24: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardRewardRowStackViewViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift:13:15: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FindFriendsFacebookConnectCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift:12:13: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FindFriendsFriendFollowCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/LiveStreamDiscoveryLiveNowCellViewModelTests.swift:11:13: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'LiveStreamDiscoveryLiveNowCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/LiveStreamDiscoveryUpcomingAndReplayCellViewModel.swift:28:20: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'LiveStreamDiscoveryUpcomingAndReplayCellViewModel' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/MostPopularSearchProjectCellViewModelTests.swift:8:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'MostPopularSearchProjectCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/ProjectActivityNegativeStateChangeCellViewModel.swift:22:20: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectActivityNegativeStateChangeCellViewModel' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/ProjectActivityNegativeStateChangeCellViewModelTests.swift:8:22: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectActivityNegativeStateChangeCellViewModelTests' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/TwoFactorViewModel.swift:71:26: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.BackgroundImageLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.CreatorLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.OpenTokLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.UserLenses.swift:4:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamChatMessage.swift:64:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEventsEnvelope.swift:20:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamSubscribeEnvelope.swift:20:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:232:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:305:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:358:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Callsite.swift:8:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_CallsiteBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Callsite.swift:10:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_CallsiteBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Example.swift:11:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Example.swift:13:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/ExampleMetadata.swift:8:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleMetadataBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/ExampleMetadata.swift:10:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleMetadataBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Filter.swift:8:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_FilterBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Filter.swift:10:18: error: Type Name Violation: Type name should only contain alphanumeric characters: '_FilterBase' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickFocusedTests/FocusedTests.swift:5:7: error: Type Name Violation: Type name should only contain alphanumeric characters: 'FunctionalTests_FocusedSpec_SharedExamplesConfiguration' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickFocusedTests/FocusedTests.swift:14:7: error: Type Name Violation: Type name should only contain alphanumeric characters: 'FunctionalTests_FocusedSpec_Behavior' (type_name)
⚠️ This PR introduced a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickFocusedTests/FocusedTests.swift:28:7: error: Type Name Violation: Type name should only contain alphanumeric characters: '_FunctionalTests_FocusedSpec_Focused' (type_name)
⚠️ Danger found 252 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 122.
264 Messages
📖 Linting Aerial with this PR took 0.48s vs 0.42s on master (14% slower)
📖 Linting Alamofire with this PR took 4.15s vs 3.41s on master (21% slower)
📖 Linting Firefox with this PR took 14.53s vs 13.2s on master (10% slower)
📖 Linting Kickstarter with this PR took 21.45s vs 21.12s on master (1% slower)
📖 Linting Moya with this PR took 1.84s vs 1.88s on master (2% faster)
📖 Linting Nimble with this PR took 1.99s vs 1.99s on master (0% slower)
📖 Linting Quick with this PR took 0.58s vs 0.58s on master (0% slower)
📖 Linting Realm with this PR took 3.61s vs 3.69s on master (2% faster)
📖 Linting SourceKitten with this PR took 1.17s vs 1.16s on master (0% slower)
📖 Linting Sourcery with this PR took 5.1s vs 5.08s on master (0% slower)
📖 Linting Swift with this PR took 14.54s vs 13.97s on master (4% slower)
📖 Linting WordPress with this PR took 16.25s vs 14.85s on master (9% slower)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/MultipartFormDataTests.swift:435:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'MultipartFormDataWriteEncodedDataToDiskTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/SessionManagerTests.swift:776:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'SessionManagerConfigurationHeadersTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/TLSEvaluationTests.swift:66:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'TLSEvaluationExpiredLeafCertificateTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:224:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyExplorationBasicX509PolicyValidationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:285:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyExplorationSSLPolicyValidationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:415:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyPerformDefaultEvaluationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:582:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyPerformRevokedEvaluationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1530:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyDisableEvaluationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1560:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyCustomEvaluationTestCase' (type_name)
📖 This PR fixed a violation in Alamofire: /Users/distiller/project/osscheck/Alamofire/Tests/ServerTrustPolicyTests.swift:1594:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ServerTrustPolicyCertificatesInBundleTestCase' (type_name)
📖 This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Browser/SearchLoader.swift:22:1: error: Type Name Violation: Type name should only contain alphanumeric characters: '_SearchLoader' (type_name)
📖 This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Home/RecentlyClosedTabsPanel.swift:81:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'RecentlyClosedTabsPanelSiteTableViewController' (type_name)
📖 This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Client/Frontend/Widgets/ToggleButton.swift:7:9: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'UX' (type_name)
📖 This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Push/PushConfiguration.swift:66:8: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FirefoxNightlyEnterprisePushConfiguration' (type_name)
📖 This PR fixed a violation in Firefox: /Users/distiller/project/osscheck/Firefox/Storage/SQL/SQLiteBookmarksModel.swift:248:1: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'EditableBufferBookmarksSQLiteBookmarksModelFactory' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/BackerDashboardProjectsViewControllerTests.swift:8:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'BackerDashboardProjectsViewControllerTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewControllerTests.swift:8:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DiscoveryNavigationHeaderViewControllerTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Kickstarter-iOS/Views/Controllers/ProjectPamphletContentViewControllerTests.swift:10:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectPamphletContentViewControllerTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Activity.MemberDataLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ActivityLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CheckoutEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/BackingLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CommentLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/CreatePledgeEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ConfigLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:21:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:30:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryEnvelopeLenses.swift:39:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:21:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FindFriendsEnvelopeLenses.swift:30:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FriendStatsEnvelope.StatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/FriendStatsEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/GraphCategoriesEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ItemLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/GraphCategoryLenses.swift:6:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/LocationLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/DiscoveryParamsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/MockService.swift:1186:5: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/MessageLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.DatesLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/MessageThreadLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.PersonalizationLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.MemberDataLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.PhotoLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.VideoLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Project.StatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectNotification.ProjectLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.CumulativeStatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectNotificationLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.FundingDateStatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.RewardDistributionLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.VideoStatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelope.ReferrerStatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectStatsEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/Reward.ShippingLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/RewardItemLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ShippingRuleLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:56:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:102:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:111:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:125:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:139:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/PushEnvelopeLenses.swift:153:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:154:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ProjectLenses.swift:163:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/ShippingRulesEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/SubmitApplePayEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/StarEnvelopeLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/SurveyResponseLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/RewardLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.AvatarLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:23:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateDraftLenses.swift:42:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.NewsletterSubscriptionsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UpdateLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.StatsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/User.NotificationsLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/lenses/UserLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/KsApi/models/templates/CategoryTemplates.swift:3:9: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ID' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ExpandableRow.swift:9:12: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/Format.swift:391:15: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ProjectActivityData.swift:9:12: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/SelectableRow.swift:8:12: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/String+Base64Tests.swift:4:1: error: Type Name Violation: Type name should only contain alphanumeric characters: 'String_Base64Tests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/Koala/Koala.swift:2096:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardProjectsDrawerCellViewModelTests.swift:9:18: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardProjectsDrawerCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardReferrerRowStackViewViewModelTests.swift:10:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardReferrersRowStackViewViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/DashboardRewardRowStackViewViewModelTests.swift:10:18: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'DashboardRewardRowStackViewViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift:13:9: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FindFriendsFacebookConnectCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift:12:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'FindFriendsFriendFollowCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/LiveStreamDiscoveryLiveNowCellViewModelTests.swift:11:7: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'LiveStreamDiscoveryLiveNowCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/LiveStreamDiscoveryUpcomingAndReplayCellViewModel.swift:28:14: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'LiveStreamDiscoveryUpcomingAndReplayCellViewModel' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/MostPopularSearchProjectCellViewModelTests.swift:8:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'MostPopularSearchProjectCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/ProjectActivityNegativeStateChangeCellViewModel.swift:22:14: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectActivityNegativeStateChangeCellViewModel' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/ProjectActivityNegativeStateChangeCellViewModelTests.swift:8:16: warning: Type Name Violation: Type name should be between 3 and 40 characters long: 'ProjectActivityNegativeStateChangeCellViewModelTests' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/Library/ViewModels/TwoFactorViewModel.swift:71:21: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.BackgroundImageLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.CreatorLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.OpenTokLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/lenses/LiveStreamEvent.UserLenses.swift:4:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamChatMessage.swift:64:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEventsEnvelope.swift:20:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamSubscribeEnvelope.swift:20:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:232:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:305:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Kickstarter: /Users/distiller/project/osscheck/Kickstarter/LiveStream/Models/LiveStreamEvent.swift:358:10: error: Type Name Violation: Type name should start with an uppercase character: 'lens' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Callsite.swift:8:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_CallsiteBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Callsite.swift:10:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_CallsiteBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Example.swift:11:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Example.swift:13:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/ExampleMetadata.swift:8:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleMetadataBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/ExampleMetadata.swift:10:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_ExampleMetadataBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Filter.swift:8:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_FilterBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Sources/Quick/Filter.swift:10:12: error: Type Name Violation: Type name should only contain alphanumeric characters: '_FilterBase' (type_name)
📖 This PR fixed a violation in Quick: /Users/distiller/project/osscheck/Quick/Tests/QuickTests/QuickFocusedTests/FocusedTests.swift:5:1: error: Type Name Violation: Type name should only contain alphanumeric characters: 'FunctionalTests_FocusedSpec_SharedExamplesConfiguration' (type_name)
⚠️ Danger found 264 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 132.

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #2023 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2023   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         254      254           
  Lines       14863    14863           
  Branches      967      967           
=======================================
  Hits        13326    13326           
  Misses       1519     1519           
  Partials       18       18
Impacted Files Coverage Δ
...ts/SwiftLintFrameworkTests/TypeNameRuleTests.swift 100% <100%> (ø) ⬆️
Source/SwiftLintFramework/Rules/TypeNameRule.swift 93.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be57d64...b204c18. Read the comment docs.

@marcelofabri marcelofabri merged commit a278239 into realm:master Jan 27, 2018
@marcelofabri marcelofabri deleted the type_name_location branch January 27, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants