Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SourceKit to validate associatedtype and typealias in type_name rule when linting with Swift 4.1 #2029

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Conversation

marcelofabri
Copy link
Collaborator

Part of #2021

…ame` rule when linting with Swift 4.1

Part of #2021
@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.45s vs 0.41s on master (9% slower)
📖 Linting Alamofire with this PR took 3.43s vs 3.47s on master (1% faster)
📖 Linting Firefox with this PR took 13.3s vs 13.46s on master (1% faster)
📖 Linting Kickstarter with this PR took 21.02s vs 21.12s on master (0% faster)
📖 Linting Moya with this PR took 1.86s vs 1.89s on master (1% faster)
📖 Linting Nimble with this PR took 1.99s vs 1.94s on master (2% slower)
📖 Linting Quick with this PR took 0.58s vs 0.57s on master (1% slower)
📖 Linting Realm with this PR took 3.64s vs 3.59s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.16s vs 1.11s on master (4% slower)
📖 Linting Sourcery with this PR took 4.98s vs 5.04s on master (1% faster)
📖 Linting Swift with this PR took 14.48s vs 14.22s on master (1% slower)
📖 Linting WordPress with this PR took 15.39s vs 15.16s on master (1% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2029 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.02%     
==========================================
  Files         254      254              
  Lines       14863    14867       +4     
  Branches      967      968       +1     
==========================================
+ Hits        13326    13328       +2     
- Misses       1519     1521       +2     
  Partials       18       18
Impacted Files Coverage Δ
Source/SwiftLintFramework/Rules/TypeNameRule.swift 91.04% <50%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a278239...4c8df19. Read the comment docs.

@marcelofabri marcelofabri merged commit bc031e4 into realm:master Jan 29, 2018
@marcelofabri marcelofabri deleted the type-name-swift-4.1 branch January 29, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants