Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical parameter alignment on call rule #1484

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Vertical parameter alignment on call rule #1484

merged 3 commits into from
Jun 13, 2017

Conversation

marcelofabri
Copy link
Collaborator

@marcelofabri marcelofabri commented May 2, 2017

Fixes #1037

TODO:

  • Add proper examples/tests
  • Add CHANGELOG entry
  • Think what to do with MasterRuleList.swift (probably that shouldn't trigger)
  • Check number of violations in oss-check to see if this should be opt-in or default rule (my bet is that it'll trigger LOTS of violations)

@SwiftLintBot
Copy link

SwiftLintBot commented May 2, 2017

1891 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L65:26: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/Preferences.swift#L75:26: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L119:35: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L164:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L165:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L166:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L169:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L170:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L171:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/PreferencesWindowController.swift#L385:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L66:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L80:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L81:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L88:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L89:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L104:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L105:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L106:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FirefoxAccount.swift#L107:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L14:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAClient10.swift#L169:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L75:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L76:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L91:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L92:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L93:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxALoginStateMachine.swift#L133:29: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/SyncAuthState.swift#L135:29: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L97:29: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L111:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L112:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L310:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L316:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L317:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L323:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L324:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L325:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L326:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/FxAState.swift#L327:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L14:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L117:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Account/TokenServerClient.swift#L170:33: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Application/AdjustIntegration.swift#L99:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L65:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L66:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L67:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Application/QuickActions.swift#L68:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L160:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L161:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L163:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L164:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L166:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L167:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L169:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L170:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L172:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Extensions/UIAlertControllerExtensions.swift#L173:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L32:24: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L29:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift#L62:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift#L63:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift#L70:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift#L71:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PagingPasscodeViewController.swift#L87:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L119:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L120:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L123:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L124:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L176:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L51:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L52:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L57:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L62:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L66:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L77:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/Authenticator.swift#L121:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardTableViewCell.swift#L110:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BackForwardTableViewCell.swift#L112:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserPrompts.swift#L46:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserPrompts.swift#L47:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L137:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L152:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L67:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L68:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L69:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L70:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L80:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L161:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L165:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L166:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L167:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L168:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L181:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L74:45: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L75:45: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L66:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L67:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L72:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L84:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L85:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L86:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L163:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L164:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L204:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/LoginsHelper.swift#L205:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/QRCodeViewController.swift#L148:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L46:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L51:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L59:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L64:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L78:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L208:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L212:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ Danger found 1891 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 113.
12 Messages
📖 Linting Aerial with this PR took 0.55s vs 0.37s on master (48% slower)
📖 Linting Alamofire with this PR took 3.44s vs 2.5s on master (37% slower)
📖 Linting Firefox with this PR took 13.44s vs 11.99s on master (12% slower)
📖 Linting Kickstarter with this PR took 14.99s vs 14.02s on master (6% slower)
📖 Linting Moya with this PR took 0.91s vs 0.8s on master (13% slower)
📖 Linting Nimble with this PR took 1.63s vs 1.63s on master (0% slower)
📖 Linting Quick with this PR took 0.5s vs 0.54s on master (7% faster)
📖 Linting Realm with this PR took 2.35s vs 2.21s on master (6% slower)
📖 Linting SourceKitten with this PR took 1.06s vs 0.98s on master (8% slower)
📖 Linting Sourcery with this PR took 3.59s vs 3.12s on master (15% slower)
📖 Linting Swift with this PR took 11.5s vs 10.64s on master (8% slower)
📖 Linting WordPress with this PR took 12.03s vs 10.84s on master (10% slower)

Generated by 🚫 Danger

@marcelofabri
Copy link
Collaborator Author

Definitely opt-in 😂

@marcelofabri marcelofabri changed the title [WIP] Vertical parameter alignment on call rule Vertical parameter alignment on call rule May 4, 2017
@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #1484 into master will increase coverage by 0.05%.
The diff coverage is 97.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   88.02%   88.07%   +0.05%     
==========================================
  Files         193      194       +1     
  Lines        9661     9695      +34     
==========================================
+ Hits         8504     8539      +35     
+ Misses       1157     1156       -1
Impacted Files Coverage Δ
.../SwiftLintFrameworkTests/SourceKitCrashTests.swift 81.96% <0%> (ø) ⬆️
Source/swiftlint/Commands/AutoCorrectCommand.swift 0% <0%> (ø) ⬆️
Tests/SwiftLintFrameworkTests/ReporterTests.swift 96.15% <100%> (ø) ⬆️
...ce/SwiftLintFramework/Rules/OpeningBraceRule.swift 92.98% <100%> (ø) ⬆️
...urce/SwiftLintFramework/Rules/LineLengthRule.swift 91.66% <100%> (+0.1%) ⬆️
...mework/Rules/ConditionalReturnsOnNewlineRule.swift 94.11% <100%> (ø) ⬆️
...iftLintFramework/Rules/TrailingSemicolonRule.swift 100% <100%> (ø) ⬆️
...ramework/Rules/LegacyNSGeometryFunctionsRule.swift 100% <100%> (ø) ⬆️
...amework/Rules/OperatorFunctionWhitespaceRule.swift 100% <100%> (ø) ⬆️
...SwiftLintFramework/Rules/TrailingNewlineRule.swift 93.54% <100%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ca864...64585a5. Read the comment docs.

@marcelofabri
Copy link
Collaborator Author

@jpsim I'd love to get this in before cutting a pre-release 😊

@marcelofabri marcelofabri merged commit c08a133 into realm:master Jun 13, 2017
@marcelofabri marcelofabri deleted the vertical_parameter_alignment_on_call branch June 13, 2017 16:01
@marcelofabri
Copy link
Collaborator Author

Giphy

@codytwinton
Copy link
Contributor

@marcelofabri - For some reason, when I run:

swiftlint rules vertical_parameter_alignment_on_call

I get this response:

No rule with identifier: vertical_parameter_alignment_on_call

@jpsim
Copy link
Collaborator

jpsim commented Jul 6, 2017

@codytwinton what version of SwiftLint are you running? This rule was first introduced in 0.20.0.

@codytwinton
Copy link
Contributor

I'm using version 0.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants