New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private_over_fileprivate and strict_fileprivate rules #1656
Conversation
In the end, I think it's better to go with two different rules so it's easier to understand what each of them validates (with examples). |
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
=========================================
+ Coverage 87.25% 87.3% +0.05%
=========================================
Files 198 200 +2
Lines 9840 9887 +47
=========================================
+ Hits 8586 8632 +46
- Misses 1254 1255 +1
Continue to review full report at Codecov.
|
Good call. |
Continued from #1489. Adds
private_over_fileprivate
correctable rule andstrict_fileprivate
opt-in rule.Fixes #1469, #1058
// cc @masters3d