New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule request: private is preferred over fileprivate #1058

Closed
marcelofabri opened this Issue Dec 25, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@marcelofabri
Collaborator

marcelofabri commented Dec 25, 2016

Because of Swift 3 migration, lots of declarations wouldn't need to be fileprivate.

@jpsim

This comment has been minimized.

Show comment
Hide comment
@jpsim

jpsim Dec 25, 2016

Collaborator

Once SwiftLint has its "compiled" mode we can even do this for internal.

Collaborator

jpsim commented Dec 25, 2016

Once SwiftLint has its "compiled" mode we can even do this for internal.

@marcelofabri

This comment has been minimized.

Show comment
Hide comment
@marcelofabri

marcelofabri Jul 4, 2017

Collaborator

I'm closing this since #1656 was merged and it finds top level fileprivate declarations, but also has a rule to trigger on all fileprivate usage. This second one will be useful when using Swift 4, since basically it'll make possible to convert all the "acceptable" usages of fileprivate to private.

Collaborator

marcelofabri commented Jul 4, 2017

I'm closing this since #1656 was merged and it finds top level fileprivate declarations, but also has a rule to trigger on all fileprivate usage. This second one will be useful when using Swift 4, since basically it'll make possible to convert all the "acceptable" usages of fileprivate to private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment