Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule request: private is preferred over fileprivate #1058

Closed
marcelofabri opened this issue Dec 25, 2016 · 2 comments
Closed

Rule request: private is preferred over fileprivate #1058

marcelofabri opened this issue Dec 25, 2016 · 2 comments
Labels
rule-request Requests for a new rules.

Comments

@marcelofabri
Copy link
Collaborator

Because of Swift 3 migration, lots of declarations wouldn't need to be fileprivate.
@marcelofabri marcelofabri added the rule-request Requests for a new rules. label Dec 25, 2016
@jpsim
Copy link
Collaborator

jpsim commented Dec 25, 2016

Once SwiftLint has its "compiled" mode we can even do this for internal.

@marcelofabri marcelofabri mentioned this issue May 1, 2017
Closed
@masters3d masters3d mentioned this issue May 3, 2017
Closed
@marcelofabri marcelofabri mentioned this issue Jul 3, 2017
Merged
@marcelofabri
Copy link
Collaborator Author

I'm closing this since #1656 was merged and it finds top level fileprivate declarations, but also has a rule to trigger on all fileprivate usage. This second one will be useful when using Swift 4, since basically it'll make possible to convert all the "acceptable" usages of fileprivate to private.

@cyril-lepottier cyril-lepottier mentioned this issue Jan 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @marcelofabri