Add support for optional 'error' severity level in configurations #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Actually, that behavior was not the right one 😅 |
marcelofabri
force-pushed
the
mf-optional-severity-configuration
branch
from
799a438
to
a4aeaed
Compare
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
+ Coverage 87.36% 87.37% +0.01%
==========================================
Files 204 204
Lines 10047 10055 +8
==========================================
+ Hits 8778 8786 +8
Misses 1269 1269
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #1664
Fixes #1647
@JamieEdge, I've added some tests and changed the behavior a little so we only set the
errorlevel tonilwhen it's explicitly set in the configuration.