Statically Linked Binary #1951

norio-nomura · 2017-11-17T01:59:15Z

Use swift build --configuration release --static-swift-stdlib for building swiftlint

It will be more desirable behavior when `make install` on Linux.

jpsim · 2017-11-17T02:03:57Z

You have to run swift build -c release -Xswiftc -static-stdlib because --static-swift-stdlib is broken in current 4.x releases of Swift.

Should be fixed in future releases that include apple/swift-package-manager#1320 though.

codecov-io · 2017-11-17T02:13:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@a03f8f8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1951   +/-   ##
=========================================
  Coverage          ?   88.79%           
=========================================
  Files             ?      245           
  Lines             ?    11920           
  Branches          ?        0           
=========================================
  Hits              ?    10584           
  Misses            ?     1336           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03f8f8...7d1b401. Read the comment docs.

Homebrew uses sandbox on building bottle.

jpsim · 2017-11-17T02:36:24Z

Can you explain why this is marked as WIP?

norio-nomura · 2017-11-17T02:38:11Z

I expected to be able to install with make install on Linux, but make install is still failing on Linux:

Linking ./.build/x86_64-unknown-linux/release/swiftlint
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/usr/bin/ld.gold: error: cannot find -ldispatch
/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Request.swift.o:/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Xcode.swift.o:function globalinit_33_B1AC82A8F682C055F79D1482C920A189_func75: error: undefined reference to '_NSConcreteStackBlock'
/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Request.swift.o:/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Xcode.swift.o:function globalinit_33_B1AC82A8F682C055F79D1482C920A189_func75: error: undefined reference to '_Block_copy'
/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Request.swift.o:/SwiftLint/.build/x86_64-unknown-linux/release/SourceKittenFramework.build/Xcode.swift.o:function globalinit_33_B1AC82A8F682C055F79D1482C920A189_func75: error: undefined reference to '_Block_release'
…

norio-nomura · 2017-11-17T02:41:35Z

Can you explain why this is marked as WIP?

It also changed to using /usr/bin/install instead of cp, and I'm still testing this for Homebrew.

norio-nomura · 2017-11-17T03:03:58Z

Using following patch for Formula/swiftlint.rb:

diff --git a/Formula/swiftlint.rb b/Formula/swiftlint.rb
index 867b09adc..f4d426cb7 100644
--- a/Formula/swiftlint.rb
+++ b/Formula/swiftlint.rb
@@ -4,7 +4,7 @@ class Swiftlint < Formula
   url "https://github.com/realm/SwiftLint.git",
       :tag => "0.24.0",
       :revision => "06ece1ea8dbeb3bc421e54f907e906cac32038d5"
-  head "https://github.com/realm/SwiftLint.git"
+  head "https://github.com/realm/SwiftLint.git", :branch => "nn-single-binary"
 
   bottle do
     cellar :any

Installing by Homebrew:

$ brew install --HEAD swiftlint
==> Cloning https://github.com/realm/SwiftLint.git
Updating /Users/norio/Library/Caches/Homebrew/swiftlint--git
==> Checking out branch nn-single-binary
Synchronizing submodule url for 'Carthage/Checkouts/Nimble'
Synchronizing submodule url for 'Carthage/Checkouts/Quick'
Synchronizing submodule url for 'Carthage/Checkouts/Result'
Synchronizing submodule url for 'Carthage/Checkouts/xcconfigs'
Synchronizing submodule url for 'Externals/Nimble'
Synchronizing submodule url for 'Carthage/Checkouts/Commandant'
Synchronizing submodule url for 'Carthage/Checkouts/Result'
Synchronizing submodule url for 'Carthage/Checkouts/SWXMLHash'
Synchronizing submodule url for 'Carthage/Checkouts/Yams'
Synchronizing submodule url for 'Carthage/Checkouts/xcconfigs'
Synchronizing submodule url for 'Carthage/Checkouts/Nimble'
Synchronizing submodule url for 'Carthage/Checkouts/Quick'
Synchronizing submodule url for 'Carthage/Checkouts/Result'
Synchronizing submodule url for 'Carthage/Checkouts/xcconfigs'
Synchronizing submodule url for 'Externals/Nimble'
==> make prefix_install PREFIX=/usr/local/Cellar/swiftlint/HEAD-745fc95 TEMPORARY_FOLDER=/private/tmp/swiftlint-20171117-4617-12638j/SwiftLint.dst
🍺  /usr/local/Cellar/swiftlint/HEAD-745fc95: 6 files, 15.4MB, built in 3 minutes 33 seconds
brew install --HEAD swiftlint  238.22s user 43.45s system 129% cpu 3:38.13 total

norio-nomura · 2017-11-17T03:06:25Z

For now, I am giving up make install on Linux and removing WIP.

jpsim · 2017-11-17T03:54:40Z

Makefile

-install: uninstall package
-	sudo installer -pkg SwiftLint.pkg -target /
+install:
+	swift package clean


Should this go in clean?

Before this PR, clean was triggered by install > package > installables > clean.
I deleted those dependencies considering make install executing on Linux.
I put swift package clean here to get closer to the previous behavior, but that may not be necessary here. 🤔

If we only use test as a target that uses xcodebuild, we can change it to somewhat simpler one.

Change `all` target to execute `swift build` instead of `xcodebuild`.

It became unnecessary in Swift 4.0.

norio-nomura · 2017-11-17T05:06:05Z

Updated.

This makes `make install` possible on Linux.

norio-nomura · 2017-11-19T04:08:53Z

Added workaround for SR-6434 on Linux.

jpsim

👌 excellent

norio-nomura · 2017-11-20T23:22:00Z

Thanks! 🙏

norio-nomura added 2 commits November 17, 2017 09:53

Use SwiftPM to build installables

67a8fc3

Remove uninstall and package dependencies from install

adf58cf

It will be more desirable behavior when `make install` on Linux.

Apply workaround for apple/swift-package-manager#1320

4cc2bf3

norio-nomura added 2 commits November 17, 2017 11:15

Add destination path as argument of install for compatibility with Linux

2fef26e

Use --disable-sandbox in prefix_install used by Homebrew

1ca0547

Homebrew uses sandbox on building bottle.

Create destination directory by install -d

745fc95

norio-nomura changed the title ~~[WIP] Single Binary~~ Single Binary Nov 17, 2017

jpsim reviewed Nov 17, 2017

View reviewed changes

Refactor Makefile

224f44e

Change `all` target to execute `swift build` instead of `xcodebuild`.

norio-nomura force-pushed the nn-single-binary branch from beb3c0a to 224f44e Compare November 17, 2017 04:53

norio-nomura mentioned this pull request Nov 17, 2017

Clean up Makefile #1950

Closed

norio-nomura added 3 commits November 17, 2017 13:57

Stop removing test bundle before docker_test

4ca2665

It became unnecessary in Swift 4.0.

Remove unused variables

69b2276

Use SWIFTLINT_EXECUTABLE

7d1b401

norio-nomura changed the title ~~Single Binary~~ Statically Linked Binary Nov 18, 2017

Use -static-stdlib only when building on Darwin

72b8dec

This makes `make install` possible on Linux.

norio-nomura added a commit to jpsim/SourceKitten that referenced this pull request Nov 19, 2017

Same as realm/SwiftLint#1951

f76e35f

norio-nomura mentioned this pull request Nov 19, 2017

[WIP] Statically Linked Binary jpsim/SourceKitten#443

Merged

jpsim approved these changes Nov 20, 2017

View reviewed changes

jpsim merged commit 9f3154e into master Nov 20, 2017

jpsim deleted the nn-single-binary branch November 20, 2017 19:00

norio-nomura mentioned this pull request Nov 20, 2017

Distribute a binary built with swiftpm for 0 dependencies #1395

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Statically Linked Binary #1951

Statically Linked Binary #1951

norio-nomura commented Nov 17, 2017

jpsim commented Nov 17, 2017

codecov-io commented Nov 17, 2017 •

edited

jpsim commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

jpsim Nov 17, 2017

norio-nomura Nov 17, 2017 •

edited

norio-nomura Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 19, 2017

jpsim left a comment

norio-nomura commented Nov 20, 2017

Statically Linked Binary #1951

Statically Linked Binary #1951

Conversation

norio-nomura commented Nov 17, 2017

jpsim commented Nov 17, 2017

codecov-io commented Nov 17, 2017 • edited

Codecov Report

jpsim commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 17, 2017

jpsim Nov 17, 2017

Choose a reason for hiding this comment

norio-nomura Nov 17, 2017 • edited

Choose a reason for hiding this comment

norio-nomura Nov 17, 2017

Choose a reason for hiding this comment

norio-nomura commented Nov 17, 2017

norio-nomura commented Nov 19, 2017

jpsim left a comment

Choose a reason for hiding this comment

norio-nomura commented Nov 20, 2017

codecov-io commented Nov 17, 2017 •

edited

norio-nomura Nov 17, 2017 •

edited