Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new non_optional_string_data_conversion rule #5264

Merged
merged 9 commits into from
Dec 2, 2023
Merged

Add a new non_optional_string_data_conversion rule #5264

merged 9 commits into from
Dec 2, 2023

Conversation

ben-p-commits
Copy link
Contributor

This rule was inspired by this issue: #5263.

I'm fairly new to SwiftSyntax so more efficient ideas/approaches are welcome 🙏🏻.

@ben-p-commits ben-p-commits mentioned this pull request Oct 4, 2023
Closed
2 tasks
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 4, 2023 •
edited
Loading

472 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:249:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:270:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:308:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:27:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:54:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:74:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:436:33: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:478:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:320:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Alamofire: /Example/Source/DetailViewController.swift:133:39: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /App/BraveWidgets/LockScreenFavoriteWidget.swift:160:59: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /App/l10n/tools/download-translations-from-transifex.swift:29:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/DeviceCheck/DeviceCheck.swift:357:42: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/New Tab Page/Backgrounds/NewTabPageP3AHelper.swift:110:18: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Search/BraveSearchManager.swift:147:42: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/Search/BraveSearchManager.swift:225:36: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/User Scripts/FarblingProtectionHelper.swift:90:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Browser/User Scripts/ScriptFactory.swift:133:18: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/Frontend/Settings/Debug/LocalStateInspectorView.swift:46:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/AdblockRustEngine.swift:65:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/DebouncingService.swift:156:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/DownloadResourceInterface.swift:110:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:41:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:64:14: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:72:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/BraveShared/Extensions/JSONSerializationExtensions.swift:14:19: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Keychain.swift:91:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/BraveWallet/Settings/IPFSCustomGatewayView.swift:115:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Growth/URP/UrpService.swift:122:74: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Growth/URP/UrpService.swift:63:65: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Shared/Extensions/WKWebViewExtensions.swift:25:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Sources/Shared/SystemUtils.swift:47:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:34:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:36:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:10:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:11:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillLoginDetailsViewModel.swift:267:67: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:898:91: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FirewallManager.swift:148:33: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/FirewallManager.swift:155:51: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/KeychainItemsDebugViewController.swift:35:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RemoteMessagingStore.swift:345:32: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGo/SaveAutofillLoginManager.swift:66:40: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutocompleteRequestTests.swift:41:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutocompleteRequestTests.swift:57:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutocompleteRequestTests.swift:75:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutocompleteRequestTests.swift:93:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutoconsentMessageProtocolTests.swift:30:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/ContentBlockerProtectionStoreTests.swift:29:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/ContentBlockingUpdatingTests.swift:294:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/EmbeddedTrackerDataTests.swift:55:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/FaviconRequestModifierTests.swift:37:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:28:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:40:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/HtmlTestDataLoader.swift:27:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/MockSecureVault.swift:34:27: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:153:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:201:21: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:251:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:307:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:374:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:74:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/WebViewTestHelper.swift:125:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /IntegrationTests/AutoconsentBackgroundTests.swift:30:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /LocalPackages/Waitlist/Sources/Waitlist/Storage/WaitlistKeychainStore.swift:79:28: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Messages/HTTPHeader.swift:125:34: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils.swift:5:40: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils.swift:6:34: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils.swift:7:52: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PerformanceTests/BookmarksExportPerformanceTests.swift:57:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in DuckDuckGo: /PerformanceTests/BookmarksImportPerformanceTests.swift:48:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /Client/Frontend/TabContentsScripts/CreditCardHelper.swift:146:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /Shared/Extensions/Data+Extension.swift:37:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /Shared/Extensions/DictionaryExtensions.swift:8:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:10:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:11:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:15:69: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:16:71: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/NetworkUtilsTests.swift:44:31: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:49:29: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:53:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:57:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:61:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:65:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1071:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1101:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1137:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Kickstarter-iOS/Features/LoginTout/Controller/LoginToutViewController.swift:580:17: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/GraphSchema.swift:14:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/ServiceType.swift:482:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/ServiceTypeTests.swift:182:7: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/extensions/NSURLSession.swift:122:27: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /KsApi/lib/EncodableType.swift:27:40: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:100:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:119:67: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:203:67: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Dangerfile.swift:126:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GiphyAPI.swift:35:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:12:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:12:61: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:14:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:68:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:70:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:72:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift:222:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/Response.swift:121:32: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/Response.swift:175:46: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Sources/Moya/Response.swift:177:52: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:20:89: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:24:89: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:37:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:38:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
⚠️ Danger found 472 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 112.
16 Messages
📖 Linting Aerial with this PR took 1.18s vs 1.18s on main (0% slower)
📖 Linting Alamofire with this PR took 1.65s vs 1.63s on main (1% slower)
📖 Linting Brave with this PR took 9.23s vs 9.22s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.7s vs 4.72s on main (0% faster)
📖 Linting Firefox with this PR took 10.66s vs 10.7s on main (0% faster)
📖 Linting Kickstarter with this PR took 11.15s vs 11.2s on main (0% faster)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.32s vs 3.3s on main (0% slower)
📖 Linting Nimble with this PR took 0.83s vs 0.83s on main (0% slower)
📖 Linting PocketCasts with this PR took 9.03s vs 9.02s on main (0% slower)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 5.84s vs 5.88s on main (0% faster)
📖 Linting Sourcery with this PR took 2.8s vs 2.81s on main (0% faster)
📖 Linting VLC with this PR took 1.57s vs 1.56s on main (0% slower)
📖 Linting Wire with this PR took 19.82s vs 19.9s on main (0% faster)
📖 Linting WordPress with this PR took 13.5s vs 13.51s on main (0% faster)

Generated by 🚫 Danger

SimplyDanny
SimplyDanny requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing up this nice rule idea!

Please rebase your PR first as there have been quite some changes recently. Also, the OSS checks look broken. Other than that, I added a few comments.

Source/SwiftLintBuiltInRules/Rules/Lint/NonOptionalStringDataConversionRule.swift Outdated Show resolved Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/NonOptionalStringDataConversionRule.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@SimplyDanny SimplyDanny linked an issue Oct 16, 2023 that may be closed by this pull request
Rule Request: Prefer non-optional UTF8 String <-> Data conversion #5263
Closed
2 tasks
@ben-p-commits
Copy link
Contributor Author

Thanks for bringing up this nice rule idea!

Please rebase your PR first as there have been quite some changes recently. Also, the OSS checks look broken. Other than that, I added a few comments.

Hey @SimplyDanny - the OSS violations being picked up now seem legitimate to me in the context of the rule that's been added. Not sure what you mean by broken here.

Also, adopted your changes but tests are failing- is CICD having issues right now with swift / Xcode versions?

@SimplyDanny
Copy link
Collaborator

Hey @SimplyDanny - the OSS violations being picked up now seem legitimate to me in the context of the rule that's been added. Not sure what you mean by broken here.

There were previously no OSS changes at all. Something was broken in the reporting. It works now. I'll have a look into them later.

Also, adopted your changes but tests are failing- is CICD having issues right now with swift / Xcode versions?

Please rebase your branch and get rid of all merge commits. There are thousands of changes in this PR at the moment. That can't be right.

@SimplyDanny SimplyDanny force-pushed the ben-p-commits/enforce-non-optional-string-data-conversion branch from fececcf to 8035573 Compare November 23, 2023 18:56
@SimplyDanny
Copy link
Collaborator

Rebased.

@SimplyDanny SimplyDanny force-pushed the ben-p-commits/enforce-non-optional-string-data-conversion branch from 8035573 to e5991aa Compare December 2, 2023 12:13
@SimplyDanny SimplyDanny enabled auto-merge (squash) December 2, 2023 12:13
@SimplyDanny SimplyDanny merged commit 544e1c6 into realm:main Dec 2, 2023
12 checks passed
u-abyss pushed a commit to u-abyss/SwiftLint that referenced this pull request Dec 16, 2023
@ben-p-commits @u-abyss
Add a new non_optional_string_data_conversion rule (realm#5264)
669b125
MartijnAmbagtsheer pushed a commit to MartijnAmbagtsheer/SwiftLint that referenced this pull request Dec 20, 2023
@ben-p-commits
Add a new non_optional_string_data_conversion rule (realm#5264)
d3a7889
@samrayner samrayner mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrayner samrayner samrayner left review comments

@SimplyDanny SimplyDanny SimplyDanny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule Request: Prefer non-optional UTF8 String <-> Data conversion
4 participants
@ben-p-commits @SwiftLintBot @SimplyDanny @samrayner