Rewrite ForceUnwrappingRule
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #542 |
This was referenced Feb 19, 2016
…les on failing test
That returns array of tupple containing "key.kind" and "byteRange" from Structure that containing the byte offset.
Add capture previous of "!" for: - checking whether SyntaxKinds is comment, string, keyword or type identifier - checking whether character is ")" - checking whether SyntaxKinds is identifier or not - SwiftDeclarationKind is one of some "Var*" and declaration containing "=" Add capture next of "!" for: - checking SyntaxKinds is identifier By applying this, the duration of linting Carthage 0.14 increase from 300ms to 380ms.
norio-nomura
force-pushed
the
nn-rewrite-force-unwrapping-rule
branch
from
bde39b5
to
f62fe10
Compare
|
Rebased |
|
Test failed on SPM.
|
|
|
|
Thanks @norio-nomura! This looks good to me. |
|
Thanks for review and merging! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #546, #547
Add capture previous of
!for:)Var*and declaration containing=Add capture next of
!for:By applying this, the duration of linting Carthage 0.14 increase from 300ms to 380ms.