Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep initializers with attributed parameters in unneeded_synthesized_initializer rule #5594

Merged
merged 1 commit into from
May 17, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Partially addresses #5153.

@SwiftLintBot
Copy link

17 Messages
📖 Linting Aerial with this PR took 0.8s vs 0.83s on main (3% faster)
📖 Linting Alamofire with this PR took 1.13s vs 1.19s on main (5% faster)
📖 Linting Brave with this PR took 6.51s vs 6.78s on main (3% faster)
📖 Linting DuckDuckGo with this PR took 3.51s vs 3.58s on main (1% faster)
📖 Linting Firefox with this PR took 9.8s vs 9.78s on main (0% slower)
📖 Linting Kickstarter with this PR took 8.12s vs 8.24s on main (1% faster)
📖 Linting Moya with this PR took 0.47s vs 0.49s on main (4% faster)
📖 Linting NetNewsWire with this PR took 2.33s vs 2.34s on main (0% faster)
📖 Linting Nimble with this PR took 0.67s vs 0.69s on main (2% faster)
📖 Linting PocketCasts with this PR took 7.02s vs 7.03s on main (0% faster)
📖 Linting Quick with this PR took 0.38s vs 0.38s on main (0% slower)
📖 Linting Realm with this PR took 4.2s vs 4.29s on main (2% faster)
📖 Linting Sourcery with this PR took 2.07s vs 2.04s on main (1% slower)
📖 Linting Swift with this PR took 3.94s vs 3.89s on main (1% slower)
📖 Linting VLC with this PR took 1.09s vs 1.1s on main (0% faster)
📖 Linting Wire with this PR took 14.73s vs 14.72s on main (0% slower)
📖 Linting WordPress with this PR took 9.91s vs 9.95s on main (0% faster)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit b42f6ff into realm:main May 17, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the keep-attributed-init branch May 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants