Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Objective-C categories on an external type get merged together #539

Closed
1ec5 opened this issue Apr 22, 2016 · 5 comments
Closed
Assignees
Labels

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Apr 22, 2016

In an Objective-C project, I have two distinct categories on NSValue, but they get merged into one. The merged category takes the name of one of the original categories and now one of my custom_categories is incomplete. This seems to match the behavior requested in #457. Merging categories into the parent documentation makes sense as long as the parent documentation is part of the same docset. But categories on an external class, such as this Foundation class, should be kept separate.

@jpsim
Copy link
Collaborator

jpsim commented Apr 22, 2016

Thanks for reporting this, and yeah I'd consider this a bug because it differs from the Swift behavior. If you add extensions to types declared outside your module, they don't get coalesced, they remain distinct.

1ec5 added a commit to mapbox/mapbox-gl-native that referenced this issue Apr 22, 2016
Consolidated NSValue categories to work around realm/jazzy#539. Documented MGLErrorCode. Moved jazzy configuration file into platform/ios/. Removed redundant include/Mapbox.h that was only being used by jazzy, now that the static frameworks’s umbrella header is based on that of the dynamic framework. Moved framework/Mapbox.h to include/Mapbox.h for consistency.
@jpmhouston
Copy link

This is affecting my project too. I'm be willing to do some debugging, can anyone give me tips on where in the source to start looking, and tips for debugging (I using homebrew-installed ruby, last couple times I tried getting some debugger tools I either found a deadend or got lost).

@karagraysen
Copy link
Contributor

Saw a few PRs merged that mentioned this issue. What's the progress on this?

@1ec5
Copy link
Collaborator Author

1ec5 commented Nov 24, 2016

No progress. That's just me referring to this issue when working around it in a library I'm working on.

@karagraysen
Copy link
Contributor

Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants