Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Objective-C categories of non-modular classes apart #719

Merged
merged 1 commit into from
Jan 7, 2017
Merged

Keep Objective-C categories of non-modular classes apart #719

merged 1 commit into from
Jan 7, 2017

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Jan 3, 2017

Fixes #539.

/cc @pcantrell

@1ec5 1ec5 added the bug label Jan 3, 2017
@1ec5 1ec5 self-assigned this Jan 3, 2017
@1ec5 1ec5 mentioned this pull request Jan 3, 2017
Merged
@pigeon-archive
Copy link
Contributor

Hey @1ec5! Thanks for filing this PR. There are four offences that RuboCop detected. Would you be able to fix those?

@1ec5
Copy link
Collaborator Author

1ec5 commented Jan 3, 2017

Yes, I’ll look into them today. Ruby is regrettably one of my weaker languages, so you’re welcome to resolve the issues if they look straightforward to you.

@pigeon-archive
Copy link
Contributor

I'm also very new to Ruby but I'll try to take a look. :-) Do what you can and if we have to, I can see if someone else is available to help. 💃

@jpsim
Copy link
Collaborator

jpsim commented Jan 6, 2017

Thanks for this @1ec5, could you please update the integration specs again now that #720 was merged?

jpsim
jpsim approved these changes Jan 6, 2017
View reviewed changes
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 feel free to merge when integration specs have been updated.

@1ec5 1ec5 force-pushed the 1ec5-objc-category-unmerge-539 branch from 2201161 to 2b8f665 Compare January 6, 2017 23:58
@1ec5 1ec5 force-pushed the 1ec5-objc-category-unmerge-539 branch from 518717e to c8d51c1 Compare January 7, 2017 09:10
@1ec5 1ec5 merged commit c8d51c1 into master Jan 7, 2017
@1ec5 1ec5 deleted the 1ec5-objc-category-unmerge-539 branch January 7, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees

@1ec5 1ec5

Labels
bug github-review-needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ec5 @pigeon-archive @jpsim