-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Configuration.objectTypes property type #6703
Conversation
These are the remaining failures, with a description of why I'm moving this to review.
This is an issue we had with Xcode 12-beta3. The issue is solved in master but not v10, which this PR branches from. Given that the object server tests fail even without my changes and my changes theoretically wouldn't affect those paths, I'm going to move this PR into review. |
It also needs an update in CHANGELOG.md |
This broke the standard database cleanup we used to have:
|
You just need a |
Tried this previously, unfortunately get an error:
|
@drinkius Did you ever figure out how to work around the error? |
@wilmarvh just sitting on Realm v5.5.2 |
This changes the property type of Realm.Configuration.objectTypes from
to
where
public typealias ObjectBase = RLMObjectBase
.This would allow developers to use embedded objects with a custom defined schema in a Realm.Configuration. Since
EmbeddedObject
inherits fromRLMObjectBase
and notRealmSwift.Object
passing an embedded object into aobjectTypes
is invalid:Developer defined classes that inherit from
Embedded Object
instead ofObject
will be never registered directly to the Realm, ie. the class won't be in the realm schema.But leaving out a custom class in the
config.objTypes
will throw this error if the embedded parent class is included:036e857 addresses a change to SwiftLint rules.