Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with encryption - meta-issue #5360

Closed
finnschiermer opened this issue Mar 29, 2022 · 7 comments
Closed

Crash with encryption - meta-issue #5360

finnschiermer opened this issue Mar 29, 2022 · 7 comments
Assignees

Comments

@finnschiermer
Copy link
Contributor

finnschiermer commented Mar 29, 2022

This is a meta-issue used to link up reports of crashes with encryption.

All issues reported after introduction of async writes/commits:

Crash during commit: #5332, realm/realm-swift#7659

Out of bounds during read_barrier: #5230, #5190 (last stack)

Reading table (during read of schema): realm/realm-swift#7640

Decryption failure when reading transaction history: realm/realm-js#4428, realm/realm-java#7652

Initial opening of file (attach): realm/realm-js#4358

Reported before introduction of async writes/commits:

None.

finnschiermer added a commit that referenced this issue Apr 6, 2022
fix for encryption/async-write bugs (#5360), flush cached blocks when unmapping
@finnschiermer
Copy link
Contributor Author

Note: turns out the fix in #5360 is likely not addressing the real issue.

@finnschiermer
Copy link
Contributor Author

finnschiermer commented Apr 7, 2022

New fix in progress here: #5375

Update: abandoned, real fix below

@finnschiermer
Copy link
Contributor Author

Fixed by #5383

@Frans-L
Copy link

Frans-L commented Apr 11, 2022

Awesome to see that there's some progress here.

By the way, is this also fixing the underhood issue #5174 ?

@bmt2018
Copy link

bmt2018 commented Apr 11, 2022

Great to hear that this issue has been fixed! Any idea when new SDK builds that incorporate this change in core will be released?

@Frans-L
Copy link

Frans-L commented Apr 25, 2022

Hey! Do you have some updates / educated guesses on whether this has been really fixed or not? This issue is still open and most of the linked issues also.

I know that no one has been able to reproduce this bug reliably. So, I understand that it's difficult hard to know whether this has been fixed or not.

However, do you have some estimation of whether this is really fixed, or was the "fix" just an attempt to fix the issue? :)

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 25, 2022

➤ Finn Andersen commented:

We consider this fixed by #5383

We have not fixed #5174 which we now believe is theoretical, not of concern on any real device for the single process case. The problem described there for supporting multiprocess with encryption remains and will be fixed as part of building that support.

@sync-by-unito sync-by-unito bot closed this as completed Apr 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants