Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include history refs in Group::write() #3039

Merged
merged 3 commits into from
May 1, 2018

Conversation

simonask
Copy link
Contributor

This should enable offline file-compaction of sync'ed Realms (both on client and server).

@simonask simonask self-assigned this Apr 30, 2018
@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #3039 into master will increase coverage by <.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
+ Coverage   93.08%   93.08%   +<.01%     
==========================================
  Files         270      270              
  Lines       78945    78971      +26     
==========================================
+ Hits        73487    73514      +27     
+ Misses       5458     5457       -1
Impacted Files Coverage Δ
src/realm/group.hpp 97.67% <100%> (+0.02%) ⬆️
src/realm/table.cpp 90.79% <100%> (ø) ⬆️
src/realm/group.cpp 93.56% <95.65%> (+0.06%) ⬆️
src/realm/column_table.cpp 83.33% <0%> (-0.11%) ⬇️
test/test_thread.cpp 82.64% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59e196...2a02159. Read the comment docs.

@realm-ci
Copy link
Contributor

Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-D

@realm-ci
Copy link
Contributor

@simonask simonask merged commit 7f0838a into master May 1, 2018
@jedelbo jedelbo deleted the su/enable-compaction-of-history branch July 3, 2018 05:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants