Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the result of @sum over a null link to a dictionary with the other collections #5080

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Nov 30, 2021

Queries of the form "link.collection.@sum = 0" match when link is null and collection is a List or Set, but didn't when collection was a Dictionary.

…her collections

Queries of the form "link.collection.@sum = 0" match when link is null and
collection is a List or Set, but didn't when collection was a Dictionary.
@tgoyne tgoyne self-assigned this Nov 30, 2021
@cla-bot cla-bot bot added the cla: yes label Nov 30, 2021
@tgoyne
Copy link
Member Author

tgoyne commented Nov 30, 2021

Failing tests are unrelated sync things which are failing on master.

Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@tgoyne tgoyne merged commit 88806b5 into master Dec 1, 2021
@tgoyne tgoyne deleted the tg/null-link-to-dictionary branch December 1, 2021 18:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants