Update error message when breaking changes are detected #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
reviewed
Jul 12, 2023
| @@ -1054,6 +1057,12 @@ static void append_errors(std::string& message, std::vector<ObjectSchemaValidati | |||
| } | |||
| } | |||
|
|
|||
| static void append_line(std::string& message, const std::string& line) | |||
There was a problem hiding this comment.
can we take line as a std::string_view rather than a const std::string& - it looks like you're always calling this with a const char* anyways, so that should avoid having to construct the temporary std::string for the line argument.
jbreams
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #6690.
☑️ ToDos
📝 Changelog update🚦 Tests (or not relevant)C-API, if public C++ API changed.