Add nightly test runs to evergreen config #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1158,7 +1161,7 @@ buildvariants: | |||
| - name: lint | |||
| distros: | |||
| - ubuntu2204-small | |||
| - name: core_sync_tests_group | |||
There was a problem hiding this comment.
core_sync_tests_group does not seem to be used anymore
There was a problem hiding this comment.
Removed the task group
| @@ -654,7 +654,8 @@ tasks: | |||
| script: ../tools/run-tests-on-exfat.sh | |||
|
|
|||
| - name: valgrind | |||
| exec_timeout_secs: 18000 | |||
| exec_timeout_secs: 14400 | |||
There was a problem hiding this comment.
I assume you checked the actual test run and this is enough
There was a problem hiding this comment.
The duration for the previous runs (on commit to master) has been just over an hour.
|
Can you trigger a nightly run to make sure everything works as expected (no timeouts, etc)? |
The nightly run is the same thing that runs now for every commit to master - I am moving some of the longer running tests from the commit builds to the nightly builds. |
jbreams
approved these changes
Jul 28, 2023
danieltabacaru
approved these changes
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Update the evergreen config.yml to specify which tests should be performed on a nightly basis.
The setup for the nightly runs is configured directly in the evergreen project. The nightly test is the same thing that is currently running every time a PR is merged to master. These changes label the longer running tests (and possibly future tests that aren't necessarily long) with
"for_nightly_tests"so they can be filtered out when running the commit to master tests. Examples:long-running-core-tests,fuzzer,valgrind.The nightly test run will be set up as a periodic build that runs all tests overnight on a daily basis.
☑️ ToDos
[ ] 📝 Changelog update[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed.