-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly test runs to evergreen config #6830
Conversation
@@ -1158,7 +1161,7 @@ buildvariants: | |||
- name: lint | |||
distros: | |||
- ubuntu2204-small | |||
- name: core_sync_tests_group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core_sync_tests_group
does not seem to be used anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the task group
@@ -654,7 +654,8 @@ tasks: | |||
script: ../tools/run-tests-on-exfat.sh | |||
|
|||
- name: valgrind | |||
exec_timeout_secs: 18000 | |||
exec_timeout_secs: 14400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you checked the actual test run and this is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duration for the previous runs (on commit to master) has been just over an hour.
Can you trigger a nightly run to make sure everything works as expected (no timeouts, etc)? |
The nightly run is the same thing that runs now for every commit to master - I am moving some of the longer running tests from the commit builds to the nightly builds. |
What, How & Why?
Update the evergreen config.yml to specify which tests should be performed on a nightly basis.
The setup for the nightly runs is configured directly in the evergreen project. The nightly test is the same thing that is currently running every time a PR is merged to master. These changes label the longer running tests (and possibly future tests that aren't necessarily long) with
"for_nightly_tests"
so they can be filtered out when running the commit to master tests. Examples:long-running-core-tests
,fuzzer
,valgrind
.The nightly test run will be set up as a periodic build that runs all tests overnight on a daily basis.
☑️ ToDos
[ ] 📝 Changelog update[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed.