Allow non-embedded links in asymmetric objects #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
force-pushed
the
kn/asymmetric-object-allow-non-embedded-links
branch
from
c0b36ef
to
9d1a1a6
Compare
tgoyne
reviewed
Sep 15, 2023
| @@ -410,18 +410,6 @@ TEST_CASE("Schema") { | |||
| "Property 'object.link' of type 'object' cannot be a link to an asymmetric object.")); | |||
| } | |||
|
|
|||
| SECTION("rejects link properties with asymmetric origin object") { | |||
There was a problem hiding this comment.
Rather than removing the test entirely the test should be changed to verify that it's allowed.
nielsenko
force-pushed
the
kn/asymmetric-object-allow-non-embedded-links
branch
from
21b80e1
to
68f38c7
Compare
nielsenko
force-pushed
the
kn/asymmetric-object-allow-non-embedded-links
branch
from
68f38c7
to
a3828f4
Compare
Pull Request Test Coverage Report for Build github_pull_request_274293
💛 - Coveralls |
tgoyne
approved these changes
Sep 15, 2023
tgoyne
added a commit
that referenced
this pull request
Sep 27, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 27, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 27, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 27, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 28, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 28, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Sep 29, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
added a commit
that referenced
this pull request
Oct 2, 2023
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
C-API, if public C++ API changed.Fixes: #6976