Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade realm-core to v12.12.0 #1025

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Upgrade realm-core to v12.12.0 #1025

merged 4 commits into from
Nov 11, 2022

Conversation

nielsenko
Copy link
Contributor

  • Update realm-core to v12.12.0
  • Core no longer likes null pointer arguments on atlas function calls

@cla-bot cla-bot bot added the cla: yes label Nov 11, 2022
@nielsenko nielsenko marked this pull request as ready for review November 11, 2022 15:28
@coveralls
Copy link

coveralls commented Nov 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3446258713

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 88.835%
Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 1 92.66%
Totals Coverage Status
Change from base Build 3429742949: -0.03%
Covered Lines: 2745
Relevant Lines: 3090
💛 - Coveralls

nirinchev
nirinchev requested changes Nov 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/user.dart Show resolved Hide resolved
@nielsenko nielsenko merged commit adbd3f3 into master Nov 11, 2022
@nielsenko nielsenko deleted the kn/upgrade-core branch November 11, 2022 16:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@blagoev blagoev Awaiting requested review from blagoev

@desistefanova desistefanova Awaiting requested review from desistefanova

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsenko @coveralls @nirinchev