Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn/fix skip then iterate bug #1410

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Oct 3, 2023

Pass _skipIndex when snapshotting results, and add missing test

Fix: #1409

@cla-bot cla-bot bot added the cla: yes label Oct 3, 2023
@nielsenko nielsenko changed the title Kn/fix skip then iterate bug kn/fix skip then iterate bug Oct 3, 2023
@nielsenko
Copy link
Contributor Author

Anyone?

@nirinchev nirinchev merged commit 037e3fa into realm:main Oct 30, 2023
1 check passed
nirinchev added a commit that referenced this pull request Oct 30, 2023
* main:
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)

# Conflicts:
#	CHANGELOG.md
#	test/asymmetric_test.g.dart
nirinchev added a commit that referenced this pull request Nov 1, 2023
* main:
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
nirinchev added a commit that referenced this pull request Nov 30, 2023
* main:
  Don't add the ISRG X1 Root on Android (#1434)
  Wait for initial sync to complete before starting the tests (#1435)
  kn/update analyzer (#1365)
  Add vNext Changelog header (#1429)
  [Release 1.6.0] (#1428)
  Upgrade to Core 13.23.4 (#1427)
  Flexible sync subscribe/unsubscribe API (#1354)
  Use default context rather than creating a new one (#1426)
  Handle duplicate certificates (#1425)
  kn/add certificate (#1378)
  asymmetric object allow non embedded links (#1402)
  Rudimentary geospatial support (#1389)
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.skip doesn't work well with .take
2 participants