Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core 13.20.1 sync errors changes #1387

Merged
merged 71 commits into from
Nov 1, 2023
Merged

Core 13.20.1 sync errors changes #1387

merged 71 commits into from
Nov 1, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Aug 25, 2023 •
edited by nirinchev
Loading

Fixes #1252
This PR proposes sync errors simplification. The reason is to achieve a reasonable mapping to the new sync errors structure in the C-API introduced by realm/realm-core@d89a330

Deprecated sync errors:

  • SyncErrorCategory
  • SyncClientErrorCode, SyncConnectionErrorCode, SyncSessionErrorCode, SyncWebSocketErrorCode, GeneralSyncErrorCode
  • SyncClientError, SyncConnectionError, SyncSessionError, SyncWebSocketError, GeneralSyncError.

Deprecated App.localAppName and App.localAppVersion, since they are not used by realm core.

@cla-bot cla-bot bot added the cla: yes label Aug 25, 2023
@desistefanova desistefanova changed the title Core13.19 sync errors changes Core 13.19.0 sync errors changes Aug 25, 2023
@desistefanova desistefanova marked this pull request as ready for review August 29, 2023 06:38
@coveralls
Copy link

coveralls commented Aug 29, 2023 •
edited by coveralls-official bot
Loading

Pull Request Test Coverage Report for Build 6710214165

  • 28 of 51 (54.9%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ds/core13.19_sync_errors_changes at 88.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/session.dart 3 5 60.0%
lib/src/user.dart 0 2 0.0%
lib/src/native/realm_core.dart 4 9 44.44%
lib/src/configuration.dart 17 31 54.84%
Totals Coverage Status
Change from base Build 6707945623: 88.6%
Covered Lines: 3312
Relevant Lines: 3737
💛 - Coveralls

@desistefanova desistefanova marked this pull request as draft August 29, 2023 07:44
@desistefanova desistefanova marked this pull request as ready for review August 29, 2023 08:16
@desistefanova desistefanova marked this pull request as draft August 29, 2023 21:34
@nielsenko nielsenko mentioned this pull request Aug 30, 2023
Merged
@nielsenko nielsenko self-requested a review September 18, 2023 14:13
@desistefanova desistefanova marked this pull request as draft September 18, 2023 14:37
desistefanova and others added 19 commits September 19, 2023 08:35
@desistefanova
use default path
31434f6
@desistefanova
Changelog update - set logs to ALL
72c7c90
@desistefanova
add generated compactTest for filter
a8be4c9
@desistefanova
reduce size of object for tests
ff08877
@desistefanova
add 2500 items
5e98792
@desistefanova
skip compact sync tests
3e2cf74
@desistefanova
Test compact methods against App service autoConfirm
004023c
@desistefanova
force changes
c5cafcd
@desistefanova
Fix schema type for compact method
ea21a6a
@nirinchev
Merge branch 'main' into ds/core13.19_sync_errors_changes
266ceb2 
* main:
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)

# Conflicts:
#	CHANGELOG.md
#	test/asymmetric_test.g.dart
@nirinchev
Clean up after merge
ac85223
@nirinchev
Fix tests
8e3b676
@nirinchev
Fix some deprecations
ce73b1a
@nirinchev
Fix more tests
64f33bb
@nirinchev
More tests
7d777c3
@nirinchev
More test fixes
9d6c325
@nirinchev
Retry compaction with sync
b10ee42
@nirinchev
Merge branch 'main' into ds/core13.19_sync_errors_changes
26b58dc
@nirinchev
Rework test a bit
7e5ebaa
@nirinchev nirinchev marked this pull request as ready for review November 1, 2023 10:20
@nirinchev nirinchev merged commit 538c6aa into main Nov 1, 2023
16 checks passed
@nirinchev nirinchev deleted the ds/core13.19_sync_errors_changes branch November 1, 2023 10:23
nirinchev added a commit that referenced this pull request Nov 1, 2023
@nirinchev
Merge branch 'main' into kn/update-analyzer
a1304fe 
* main:
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@nielsenko nielsenko mentioned this pull request Nov 13, 2023
Closed
nirinchev added a commit that referenced this pull request Nov 30, 2023
@nirinchev
Merge branch 'main' into kn/realm-maps
5dcc0ad 
* main:
  Don't add the ISRG X1 Root on Android (#1434)
  Wait for initial sync to complete before starting the tests (#1435)
  kn/update analyzer (#1365)
  Add vNext Changelog header (#1429)
  [Release 1.6.0] (#1428)
  Upgrade to Core 13.23.4 (#1427)
  Flexible sync subscribe/unsubscribe API (#1354)
  Use default context rather than creating a new one (#1426)
  Handle duplicate certificates (#1425)
  kn/add certificate (#1378)
  asymmetric object allow non embedded links (#1402)
  Rudimentary geospatial support (#1389)
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Client Error Simplification
5 participants
@desistefanova @coveralls @blagoev @nielsenko @nirinchev