Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1021: Wire up some basic dynamic setting and change notifications #1669

Merged
merged 8 commits into from
May 23, 2024

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented May 6, 2024

Fixes #1668

Additionally, had to add Realm.dynamic.create and RealmObject.dynamic.set to be able to test.

TODO:

  • Change notifications for collections of objects
  • Tests for setting of different property types
  • Changelog

@nirinchev nirinchev requested a review from nielsenko May 7, 2024 14:38
@nirinchev nirinchev marked this pull request as ready for review May 7, 2024 14:38
@nirinchev nirinchev requested a review from elle-j May 7, 2024 22:51
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we merge #1550 first?

packages/realm_dart/lib/src/realm_object.dart Outdated Show resolved Hide resolved
nirinchev and others added 2 commits May 8, 2024 14:31
Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
@nirinchev
Copy link
Member Author

I don't think this should conflict too much with #1550, but happy to merge the handles PR first.

Copy link

coveralls-official bot commented May 8, 2024

Pull Request Test Coverage Report for Build 9204124897

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 86.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/realm_class.dart 9 12 75.0%
packages/realm_dart/lib/src/realm_object.dart 14 18 77.78%
Totals Coverage Status
Change from base Build 9203807735: -0.06%
Covered Lines: 5892
Relevant Lines: 6809

💛 - Coveralls

Copy link
Member

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
packages/realm_dart/test/dynamic_realm_test.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko merged commit 2dd3bff into main May 23, 2024
53 of 55 checks passed
@nielsenko nielsenko deleted the ni/object-change branch May 23, 2024 08:15
nirinchev added a commit that referenced this pull request May 27, 2024
* main: (37 commits)
  RDART-930: Refactor handles (#1550)
  Forgot to show GeoPolygon
  Add vNext Changelog header (#1687)
  [Release 2.3.0] (#1686)
  RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683)
  RDART-1021: Wire up some basic dynamic setting and change notifications (#1669)
  RDART-1022: Drop x86 as target (#1682)
  RDART-1034: Update realm-core to v14.7.0 (#1681)
  Skip select test
  RDART-1018: Fix badly generated _fromJson (#1664)
  Add vNext Changelog header (#1660)
  [Release 2.2.1] (#1659)
  Update CHANGELOG.md
  RDART-1016: Cleanup iOS podspec (#1658)
  Add vNext Changelog header (#1655)
  [Release 2.2.0] (#1654)
  RDART-1015: Update core to v14.6.2 (#1651)
  RDART-950: Update nullability annotations for base url API (#1652)
  RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646)
  RDART-1014: Bump required sdk version to ^3.3.0 (#1648)
  ...

# Conflicts:
#	CHANGELOG.md
#	packages/realm_dart/lib/src/native/realm_core.dart
#	packages/realm_dart/src/realm-core
#	packages/realm_dart/test/realm_test.dart
#	packages/realm_dart/test/session_test.dart
#	packages/realm_dart/test/test.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for listening to changes on dynamic objects
3 participants