RDART-1016: Cleanup iOS podspec #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular 'VERSIONING_SYSTEM' => 'apple-generic'. This will cause a realm_privacy_vers.c file to be formed and hence an exe to be build, which will cause trouble on app store connect.
tgoyne
reviewed
May 2, 2024
CHANGELOG.md
Outdated
| @@ -4,7 +4,7 @@ | |||
| * None | |||
|
|
|||
| ### Fixed | |||
| * None | |||
| * Avoid using `'VERSIONING_SYSTEM' => 'apple-generic'` in `ios/realm.podspec`. (Issue [#1656](https://github.com/realm/realm-dart/issues/1656)) | |||
There was a problem hiding this comment.
This doesn't really tell someone reading the changelog anything useful, since most people will have no clue what this means.
nirinchev
approved these changes
May 2, 2024
|
Nice, should we do something similar for the JS podspec? cc @kneth |
nirinchev
added a commit
that referenced
this pull request
May 27, 2024
* main: (37 commits) RDART-930: Refactor handles (#1550) Forgot to show GeoPolygon Add vNext Changelog header (#1687) [Release 2.3.0] (#1686) RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683) RDART-1021: Wire up some basic dynamic setting and change notifications (#1669) RDART-1022: Drop x86 as target (#1682) RDART-1034: Update realm-core to v14.7.0 (#1681) Skip select test RDART-1018: Fix badly generated _fromJson (#1664) Add vNext Changelog header (#1660) [Release 2.2.1] (#1659) Update CHANGELOG.md RDART-1016: Cleanup iOS podspec (#1658) Add vNext Changelog header (#1655) [Release 2.2.0] (#1654) RDART-1015: Update core to v14.6.2 (#1651) RDART-950: Update nullability annotations for base url API (#1652) RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646) RDART-1014: Bump required sdk version to ^3.3.0 (#1648) ... # Conflicts: # CHANGELOG.md # packages/realm_dart/lib/src/native/realm_core.dart # packages/realm_dart/src/realm-core # packages/realm_dart/test/realm_test.dart # packages/realm_dart/test/session_test.dart # packages/realm_dart/test/test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a fruitful discussion with @tgoyne
This PR removes some cruft from our ios podspec pod_target_xcconfig
In particular 'VERSIONING_SYSTEM' => 'apple-generic'.
This will cause a realm_privacy_vers.c file to be formed and hence an exe to be build, which will cause trouble on app store connect.
Fixes: #1656