Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

application login user #469

Merged
merged 63 commits into from
Apr 21, 2022
Merged

application login user #469

merged 63 commits into from
Apr 21, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Apr 12, 2022 •
edited by blagoev

Application login user. Fixes #407
Fixes http transport headers enumeration

nielsenko and others added 30 commits March 29, 2022 09:49
@nielsenko
Rollback Dart_WeakHandle finalizer hack
453e018
@nielsenko
Use dart main/flutter beta in github actions.
8430d42 
Drop once stable is updated with finalizer fix.
Don't merge before that!
@nielsenko
Add dart specific support for realm_http_transport_new
e847de2 
Update build
@nielsenko
Wire up realm_core
6a5c9c4
@nielsenko @blagoev
Apply suggestions from code review
fca9182 
Co-authored-by: blagoev <lubo@blagoev.com>
@nielsenko
Copy all info from realm_http_request before starting async request
435e484
@nielsenko
Added ApplicationConfiguration
d7207d9
@nielsenko
Added Application class with async logIn method (includes stubs for U…
ea8d7ef 
…ser and Credentials)
@nielsenko
Use common GCHandle class for userdata on all callbacks
a54b1a8
@nielsenko
Support hard gc handles as well, as suggested by Yavor. Ie. handles t…
6ae70e2 
…hat will keep the corresponding dart object alive.
@nielsenko
Backport to dart 2.16 where we have to work around a finalization iss…
c81e0c0 
…ue on isolate shutdown: dart-lang/sdk#48321
@nielsenko
Add support for http_transport
6899dc8
@nielsenko
Added ApplicationConfiguration
9a17d45
@nielsenko
Update docs on public interface
73e2e4c
@nielsenko
Address PR feedback
0baa62f
@nielsenko
Added Application class with async logIn method (includes stubs for U…
20e95af 
…ser)
@nielsenko
Add testWithBass function
d63f205
@desistefanova
Merge branch 'master' into realm_app_config
0cdf4b7
@desistefanova
Update CHANGELOG.md
b9cc163
@desistefanova
Merge branch 'realm_app_config' into realm_app
8448ffd
@desistefanova
Commit after merge
7ff02ef
@desistefanova
Fixes after merge
fc5e481
@desistefanova
Merge branch 'realm_app'
c1cb35e
@desistefanova
Fixes after merge
e07be97
@desistefanova
Remove user and login
b7ddc96
@desistefanova
size of handles
938a168
@desistefanova
Set size of handles
d447fe0
@desistefanova
workflow chanel = stable
ef644c5
@desistefanova
Delete realm_dart_http_transport
a132bf4
@desistefanova
remove import dart:async from tests
4e15ea7
@blagoev
Merge branch 'master' into login_user
5f3ace8 
# Conflicts:
#	CHANGELOG.md
#	lib/src/realm_class.dart
@blagoev blagoev self-assigned this Apr 20, 2022
@blagoev
support weak and persistent handles
9fc1e1b 
change user login to use persistent handle for the completer object
@blagoev blagoev marked this pull request as ready for review April 20, 2022 15:51
@blagoev blagoev requested review from nirinchev and nielsenko and removed request for nirinchev April 20, 2022 15:52
nielsenko
nielsenko reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us discuss further at the round-table tomorrow

lib/src/application.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
scripts/build-linux.sh Outdated Show resolved Hide resolved
src/realm_dart.cpp Show resolved Hide resolved
test/test.dart Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
nirinchev
nirinchev reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass - we probably need a lot more tests and also to expose the properties on the user, but I guess those can come as a follow-up PR.

lib/src/user.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
test/test.dart Show resolved Hide resolved
test/test.dart Show resolved Hide resolved
@blagoev
use named arg
5a1523e
@blagoev
rename methods
ef5e89d 
remove dead env vars usage
@blagoev
use string skip if url not present in test env
8c0deb4
@blagoev
move creation of httpTransportHandle, appConfigHandle and sycnClientC…
b37247d 
…onfigHandle inside getApp since they are not needed anywhere else. This allows the GC to collect them when out of scope. Native instances are preserved by Core
@blagoev
rename TO BAAS
9c7127d
@blagoev
rename to BAAS
7cc27d0
@blagoev
use non async login method
ec217bb
@blagoev
set skip to error if url is null
6392968
@blagoev blagoev merged commit b21f01f into master Apr 21, 2022
@blagoev blagoev deleted the login_user branch April 21, 2022 19:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev left review comments

@nielsenko nielsenko nielsenko approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App: login user
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko