Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we can optimally retrieve by PrimaryKey #402

Closed
AndyDentFree opened this issue Feb 19, 2016 · 3 comments
Closed

Ensure we can optimally retrieve by PrimaryKey #402

AndyDentFree opened this issue Feb 19, 2016 · 3 comments
Assignees
@AndyDentFree
Labels
Blocked This issue is blocked by another issue T-Enhancement
Milestone
v1.0

Comments

@AndyDentFree
Copy link
Contributor

AndyDentFree commented Feb 19, 2016 •
edited

To use objects in different threads we need the commnon approach of being able to pass the ObjectId PrimaryKey to another thread and very quickly get the object back by that id. This is also important to CreateOrUpdate scenarios.

See the Swift update by PrimaryKey
@AndyDentFree AndyDentFree self-assigned this Feb 19, 2016
@kristiandupont kristiandupont added this to the v1.0 milestone Jul 5, 2016
@AndyDentFree AndyDentFree mentioned this issue Jul 7, 2016
Closed
@AndyDentFree AndyDentFree self-assigned this Jul 12, 2016
AndyDentFree added a commit that referenced this issue Jul 25, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId
16c3689 
ObjectIdTests.cs
- added

Realm.cs
- ById added (with overloads by types)
- All<T> refactored out SchemaIfInRealm

wrappers/src/query_cs.cpp
- row_for_string_id added
AndyDentFree added a commit that referenced this issue Jul 25, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - doc updates
f3cc02c
AndyDentFree added a commit that referenced this issue Jul 25, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - Realm.cs changes adding ByID (w…
2c08af9 
…ithout massive XS reformat)
AndyDentFree referenced this issue Jul 29, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-id-#402
d76a4be 
* master:
  Add PCL built schemas into unit tests - add copyright headers
  Specific error messages for detached rows (#724)
  Add PCL built schemas into unit tests
  Fix signature mismatch in PCL ToNotifyCollectionChanged - tweak IOS options
  Fix signature mismatch in PCL ToNotifyCollectionChanged - delete bogus copy
  Fix signature mismatch in PCL ToNotifyCollectionChanged - add libwrappers.so to Droid project and ensure builds for all ABIs
  Fix signature mismatch in PCL ToNotifyCollectionChanged
  #715 Fix Weaving error
  Bump versions for 0.77.1 release
  #715 - minor test change to allow building ThreeLayerRealmXF for devices - needs to include DotNetCross.MemoryUnsafe directly
  #715 - minor test change to allow building ThreeLayerRealmXF if only build Debug Realm and for iPhoneSimulator
  #715 - minor test change to allow building ThreeLayerRealmXF if only build Debug Realm
  #715 Fix Weaving error
  £715 Fix Weaving error
  Fix tests for NuGet (#713)
  Bumped changelog

# Conflicts:
#	Realm.Shared/Realm.Shared.projitems
#	internals/Realm-dotnet Code Change Diary - Andy Dent.txt
AndyDentFree referenced this issue Aug 12, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-id-#402
5de458e 
# Conflicts:
#	Tests/IntegrationTests.Shared/IntegrationTests.Shared.projitems
#	internals/Realm-dotnet Code Change Diary - Andy Dent.txt
AndyDentFree referenced this issue Aug 15, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-id-#402
1c72b57
AndyDentFree added a commit that referenced this issue Aug 15, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId (unfinished, needs schema refactor)
11dd3ea 
ObjectIdTests.cs
- added

Realm.cs
- ById added (with overloads by types)
- All<T> refactored out SchemaIfInRealm
- CreateRealmObjectMetadata work out index of objectId col

wrappers/query_cs.cpp
- row_for_string_id added

RealmObject.Metadata
- ObjectIdColIndex added
AndyDentFree added a commit that referenced this issue Aug 15, 2016
@AndyDentFree
#402 Retrieve by ObjectId - fix for changed columnIndex to store int
bea2c7a
AndyDentFree referenced this issue Aug 15, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-id-#402
313291d
AndyDentFree added a commit that referenced this issue Aug 15, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - string lookup test passing
f418d9d
AndyDentFree added a commit that referenced this issue Aug 16, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - add further tests for all other…
bd81fa0 
… ObjectId types and some refactoring to provide integer searches
AndyDentFree referenced this issue Aug 16, 2016
@AndyDentFree
Merge branch 'ad/feature/get-by-id-#402' of https://github.com/realm/…
a93eacd 
…realm-dotnet into ad/feature/get-by-id-#402
AndyDentFree added a commit that referenced this issue Aug 16, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - dynamic tests added and rewrote…
90daa6b 
… ObjectStore code to use find_first

(based on PR feedback, using `find_first_string` is leaner than building a Query)
AndyDentFree added a commit that referenced this issue Aug 16, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - dynamic tests fixes (previously…
33e75ac 
… doesn't compile)
AndyDentFree added a commit that referenced this issue Aug 17, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId - rewrite to move more to c++
c1f70fb 
RealmObject.cs
- Metadata - removed ObjectIdColIndex

Realm.cs
- ObjectById rewritten to pass schema, renamed ObjectForPrimaryKey to match other SDKs
- CreateRealmObjectMetadata don't work out index of objectId col
- MetadataCheckingHasObjectId - removed helper method

wrappers/query_cs.cpp
- renamed *_for_id to row_for_int_primarykey

wrappers/realm_error_type.hpp
- RealmErrorType - RealmTableHasNoPrimaryKey=22 added

wrappers/object_store.hpp/cpp
- PrimaryKeyNotDeclaredException added

wrappers/error_handling.cpp
- convert_exception - map PrimaryKeyNotDeclaredException to RealmTableHasNoPrimaryKey

RealmExceptionCodes.cs
- RealmTableHasNoPrimaryKey=22 added

RealmException.cs
- Create - added mapping RealmTableHasNoPrimaryKey to RealmClassLacksObjectIdException

ObjectIdTests.cs
- renamed PrimaryKeyTests

RealmPCL.cs
- added proxy methods for all four ObjectForPrimaryKey variants

AsyncTests.cs
- AsyncWrite_UpdateViaPrimaryKey use ObjectForPrimaryKey instead of a search

 General search and replace ObjectId with PrimaryKey
@AndyDentFree
Copy link
Contributor Author

Moved back from review because approach I took was rejected. Now waiting for #750 so I can use a new exception type from ObjectStore rather than adding one.

@AndyDentFree AndyDentFree added Blocked This issue is blocked by another issue S:P1 Backlog and removed S:In Progress Blocked This issue is blocked by another issue labels Aug 19, 2016
AndyDentFree added a commit that referenced this issue Aug 23, 2016
@AndyDentFree
#402 Retrieve Optimally by ObjectId
56d23ac 
ObjectSchema.cs
- FromType - also mark as indexed if IsPrimaryKey
AndyDentFree referenced this issue Aug 23, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-id-#402
144fb13 
# Conflicts:
#	CHANGELOG.md
#	Realm.Shared/Realm.cs
#	Realm.Shared/RealmObject.cs
#	Realm.Shared/Schema/Property.cs
#	Realm.Shared/Schema/RealmSchema.cs
#	Realm.Shared/linq/RealmResults.cs
#	Realm.Shared/native/NativeTable.cs
#	internals/Realm-dotnet Code Change Diary - Andy Dent.txt
#	wrappers/src/object-store/src/object_store.hpp
#	wrappers/src/query_cs.cpp
AndyDentFree added a commit that referenced this issue Aug 23, 2016
@AndyDentFree
#402 Retrieve Optimally by PrimaryKey
76d50c0 
Theoretically complete but not building due weird forwarding error
committing to test elsewhere
AndyDentFree added a commit that referenced this issue Aug 25, 2016
@AndyDentFree
#402 working as far as crashing due to incorrect column index in C# c…
26e9401 
…opy of schema

twofold fix:
- remove bogus `PrimaryKeyAttribute.cs` from IntegrationTests, which was shielding the correct one from `Realm.Shared` so preventing C# side setting up schema to say any primary keys
- schema_create now set the primary_key string to name of property specified as [PrimaryKey]
@AndyDentFree AndyDentFree changed the title Ensure we can optimally retrieve by ObjectId Ensure we can optimally retrieve by PrimaryKey Aug 25, 2016
@AndyDentFree AndyDentFree added the Blocked This issue is blocked by another issue label Aug 25, 2016
@AndyDentFree
Copy link
Contributor Author

Think this is blocked by #789 now other bugs are fixed, as it is crashing because the schema we pass in has bogus column indexes.

AndyDentFree added a commit that referenced this issue Aug 25, 2016
@AndyDentFree
Merge PrimaryKey work from branch get-by-id-#402 on to master using O…
bc6c5d3 
…bjectStore as submodule
@AndyDentFree
Copy link
Contributor Author

Should post an update on the Akavache branch when this ships.

AndyDentFree referenced this issue Aug 29, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/get-by-primary-key-#402
1b849c2
AndyDentFree added a commit that referenced this issue Aug 29, 2016
@AndyDentFree
#402 Retrieve Optimally by PrimaryKey - revert to using a column inde…
0b08fe1 
…x as no schema info available
AndyDentFree added a commit that referenced this issue Aug 29, 2016
@AndyDentFree
#402 Comment correction for PR
fc6d964
AndyDentFree added a commit that referenced this issue Aug 29, 2016
@AndyDentFree
Merge pull request #799 from realm/ad/feature/get-by-primary-key-#402
a0d18d3 
Ad/feature/get by primary key #402
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyDentFree AndyDentFree

Labels
Blocked This issue is blocked by another issue T-Enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@kristiandupont @AndyDentFree