-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't execute weaver multiple times #1861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
May 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could use a test.
fealebenpae
approved these changes
May 13, 2019
nirinchev
pushed a commit
that referenced
this pull request
Jun 13, 2019
* wip * more wip * Fold databinding logic back to Realm package (#1850) * more wip * Fold databinding logic back to Realm package * remove weaver config * Update Core, Sync, and Object Store * Add Realm.Server stuff * ignore FodyWeavers.xsd * update test running * do not build server wrappers for Android until new NDK * bring back deleteDir in nodeWithCleanup * Update test runners (#1851) * Update test runners to Nunit 3.11.0 * wip * Delete FodyWeavers.xsd * Delete FodyWeavers.xsd * Delete FodyWeavers.xsd * run tests * Android tests * Disable test parallelization * comment out assertion * remove iOS binding redirects * Windows tests * more ci tests work * Bring back docs (#1853) * wip * Get docs to work * Return the old wrapper names * Fix (delete) tests * Try to run the linker * Try to fix ios tests * Try with a different bundle id * more tests work * fix stuff * Fix the string.contains handling in the linq visitor (#1854) * Fix the string.contains handling in the linq visitor * Add changelog entry * more fixes * Fix iOS tests * props cleanup * Reference android native libraries * more fixes * move files around * fix * moar fixes * build android tests on windows * Add --nolinkaway * fix weaving the realm assembly * fix realm types in default schema * fix stuff * Add server tests (#1855) * Add server tests * Delete launchSettings.json * try to get ios tests to exit * fix server tests * fix notifier tests * run tests on xamarin.ios nodes only * Explicitly build with Windows 8.1 as the target * Add support for subscription updating and expiration (#1857) * Add support for subscription updating and expiration * Changelog * Add support for subscription inclusions (#1858) * Add support for subscription inclusions * Changelog * Don't execute weaver multiple times (#1861) * Don't execute weaver multiple times * Add test * Update OS * Fix android build * run weaver tests on CI * try to fix System.Runtime.CompilerServices.Unsafe issue * Fix failing integration test * test * use latest ROS * Downgrade the unsafe package * Pad the primitive_value struct to ensure its alignment * Ignore inconclusive weaver tests * Cleanup jenkinsfile * Workaround failing test * 😑 * Clean up the runtimes * Use the http permission API (#1864) * Rework permissions to use the http API * Fix the access level serialization * More tests and fixes * Update ROS version * Run tests on windows-02
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #1859.
TODO