Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async open from OS #1859

Merged
merged 15 commits into from
Aug 26, 2019
Merged

Use async open from OS #1859

merged 15 commits into from
Aug 26, 2019

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented May 2, 2019 •
edited
Loading

Description

Fixes #

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev mentioned this pull request May 8, 2019
Merged
3 tasks
@nirinchev nirinchev force-pushed the ni/subscription-inclusions-2 branch from acdb1c3 to db9f155 Compare May 13, 2019 10:53
@nirinchev nirinchev changed the base branch from ni/subscription-inclusions-2 to yg/realm-4.0 May 13, 2019 11:12
@nirinchev nirinchev changed the base branch from yg/realm-4.0 to master June 13, 2019 21:22
@nirinchev nirinchev marked this pull request as ready for review August 23, 2019 12:43
fealebenpae
fealebenpae requested changes Aug 23, 2019
View reviewed changes
Realm/Realm/Configurations/InMemoryConfiguration.cs Outdated Show resolved Hide resolved
Realm/Realm/Configurations/QueryBasedSyncConfiguration.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/AsyncOpenTaskHandle.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/NotifiableObjectHandleBase.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/SessionHandle.cs Outdated Show resolved Hide resolved
Tests/Realm.Tests/Server/ShouldHandleTests.cs Outdated Show resolved Hide resolved
Tests/Realm.Tests/Sync/SyncTestBase.cs Outdated Show resolved Hide resolved
Tests/Realm.Tests/Sync/SyncTestBase.cs Outdated Show resolved Hide resolved
Tests/Realm.Tests/Sync/SynchronizedInstanceTests.cs Outdated Show resolved Hide resolved
wrappers/src/async_open_task_cs.cpp Outdated Show resolved Hide resolved
nirinchev and others added 2 commits August 23, 2019 17:23
@nirinchev @fealebenpae
Update Realm/Realm/Realm.cs
d3e7386 
Co-Authored-By: Yavor Georgiev <fealebenpae@users.noreply.github.com>
@nirinchev @fealebenpae
Update Tests/Realm.Tests/Sync/SyncTestBase.cs
41140b5 
Co-Authored-By: Yavor Georgiev <fealebenpae@users.noreply.github.com>
nirinchev and others added 2 commits August 23, 2019 17:24
@nirinchev @fealebenpae
Apply suggestions from code review
1bbb834 
Co-Authored-By: Yavor Georgiev <fealebenpae@users.noreply.github.com>
@nirinchev
address comments
669c906
@nirinchev nirinchev merged commit 325d736 into master Aug 26, 2019
@nirinchev nirinchev deleted the ni/async-open branch August 26, 2019 11:07
nirinchev added a commit that referenced this pull request Aug 26, 2019
@nirinchev
Add client reset changelog entry
8243cf7 
Forgot to add it in #1859.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
T-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nirinchev @fealebenpae