Don't try to serialize the DynamicApi property
#2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
force-pushed
the
ni/fix-serialization
branch
from
4490299
to
29f7464
Compare
nirinchev
commented
Aug 24, 2021
| @@ -39,17 +41,20 @@ public abstract class RealmCollectionBase<T> | |||
| IThreadConfined, | |||
| IMetadataObject | |||
| { | |||
| private readonly List<NotificationCallbackDelegate<T>> _callbacks = new List<NotificationCallbackDelegate<T>>(); | |||
There was a problem hiding this comment.
Unfortunately, this change also reorders the members of RealmCollectionBase because they were all over the place. Apart from the reordering, the only other change is the addition of the attributes.
nirinchev
commented
Aug 24, 2021
| public abstract class RealmObjectBase | ||
| : INotifyPropertyChanged, | ||
| IThreadConfined, | ||
| INotifiable<NotifiableObjectHandleBase.CollectionChangeSet>, | ||
| IReflectableType | ||
| { | ||
| [NonSerialized, XmlIgnore] |
There was a problem hiding this comment.
The Xml serializer ignores the private/internal fields anyway.
fealebenpae
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces
[XmlIgnore]with[IgnoreDataMember]as that works for both the Xml and Json serializer. It removes[Serializable]as that was only used in theBinarySerializerwhich is very strongly obsoleted.Finally, it annotates the RealmCollectionBase properties with
[IgnoreDataMember]to make sure a json serializer doesn't try to touch them and adds tests for both Xml and Json serialization.A couple of caveats:
Fixes #2579
TODO