Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest core #2679

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Update to latest core #2679

merged 4 commits into from
Oct 18, 2021

Conversation

LaPeste
Copy link
Contributor

@LaPeste LaPeste commented Oct 13, 2021

Description

Fixes #

@cla-bot cla-bot bot added the cla: yes label Oct 13, 2021
@coveralls
Copy link

coveralls commented Oct 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1356255971

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 381 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-5.4%) to 76.919%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Exceptions/AppException.cs 1 90.0%
Realm/Realm/Realm.cs 1 90.52%
Realm/Realm/Native/HttpClientTransport.cs 2 55.67%
Realm/Realm/Sync/App.cs 2 69.09%
Realm/Realm/Helpers/SerializationHelper.cs 3 18.84%
Realm/Realm/Sync/Credentials.cs 3 64.52%
Realm/Realm/Sync/UserIdentity.cs 3 0%
Realm/Realm/Native/UserApiKey.cs 4 0%
Realm/Realm/Handles/AsyncOpenTaskHandle.cs 6 30.77%
Realm/Realm/Sync/ProgressNotifications/SyncProgress.cs 6 0%
Totals Coverage Status
Change from base Build 1337284972: -5.4%
Covered Lines: 4769
Relevant Lines: 6150
💛 - Coveralls

@LaPeste
Copy link
Contributor Author

LaPeste commented Oct 18, 2021

@nirinchev thanks to your fix for the deadlock, this PR is now passing all the tests. Shouldn't we merge it?

@nirinchev
Copy link
Member

Not yet - the deadlock fix hasn't been merged to Core.

@nirinchev nirinchev merged commit 162c9d5 into master Oct 18, 2021
@nirinchev nirinchev deleted the ac/update-to-latest-core branch October 18, 2021 20:51
nirinchev added a commit that referenced this pull request Oct 18, 2021
@nirinchev
Merge branch 'master' into ni/android-tests
0ae68d0 
* master:
  Update to latest core (#2679)
  Bring back the win81 tests (#2682)

# Conflicts:
#	wrappers/realm-core
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaPeste @coveralls @nirinchev