Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the admin api instead of the import functionality #2768

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jan 13, 2022

Description

This replace the import/export approach with using the admin API to configure BaaS apps. It's intended to prepare us for FLX where the import is not wired up yet.

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev self-assigned this Jan 13, 2022
@cla-bot cla-bot bot added the cla: yes label Jan 13, 2022
@coveralls
Copy link

coveralls commented Jan 13, 2022

Pull Request Test Coverage Report for Build 1692620183

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 549 unchanged lines in 29 files lost coverage.
  • Overall coverage decreased (-7.7%) to 74.632%

Files with Coverage Reduction New Missed Lines %
Realm/Realm/Extensions/TaskExtensions.cs 1 81.25%
Realm/Realm/Realm.cs 2 90.73%
Realm/Realm/Helpers/SerializationHelper.cs 3 18.31%
Realm/Realm/Native/AppError.cs 3 0%
Realm/Realm/Sync/UserIdentity.cs 3 0%
Realm/Realm/Handles/AppHandle.EmailPassword.cs 4 8.33%
Realm/Realm/Native/StringStringPair.cs 4 0%
Realm/Realm/Native/UserApiKey.cs 4 0%
Realm/Realm/Native/Credentials.cs 6 0%
Realm/Realm/Sync/ProgressNotifications/SyncProgress.cs 6 0%
Totals Coverage Status
Change from base Build 1688124756: -7.7%
Covered Lines: 4600
Relevant Lines: 6150

💛 - Coveralls

@papafe
Copy link
Contributor

papafe commented Jan 13, 2022

It's a little dense to follow everything, but it seems to make sense

@nirinchev nirinchev marked this pull request as ready for review January 13, 2022 13:48
@nirinchev nirinchev merged commit 8f81332 into master Jan 13, 2022
@nirinchev nirinchev deleted the ni/admin-api branch January 13, 2022 13:48
Copy link
Member

@fealebenpae fealebenpae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay , but I believe as it is written it'll only work when running against local (aka docker) baas, and not Atlas, because of how URLs are hardcoded in CreateApp. I misread the service config, it does support Atlas clusters for sync.
Also I think we might want to look at System.CommandLine when we do introduce the ability to test against an Atlas cluster.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants