Implement RefreshAsync in native #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| try | ||
| { | ||
| var didRegister = NativeMethods.refresh_async(this, GCHandle.ToIntPtr(tcsHandle), out var ex); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
| [DllImport(InteropConfig.DLL_NAME, EntryPoint = "shared_realm_get_subscriptions_version", CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern Int64 get_subscriptions_version(SharedRealmHandle realm, out NativeException ex); | ||
|
|
||
| [DllImport(InteropConfig.DLL_NAME, EntryPoint = "shared_realm_refresh_async", CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern bool refresh_async(SharedRealmHandle realm, IntPtr tcs_handle, out NativeException ex); |
Check notice
Code scanning / CodeQL
Unmanaged code
nirinchev
force-pushed
the
ni/refresh-async
branch
from
ae1b4ce
to
6f286c6
Compare
Pull Request Test Coverage Report for Build 2871119489
💛 - Coveralls |
nirinchev
requested review from
papafe,
LaPeste and
fealebenpae
and removed request for
papafe
nirinchev
commented
Dec 2, 2022
| { | ||
| HandleTaskCompletion(tcs_ptr, () => (object)true, ex); | ||
| }, null); | ||
| // The task awaiting on this tcs should only continue once the native method Realm::run_writes has finished to run. |
There was a problem hiding this comment.
Generalize this comment a little
fealebenpae
approved these changes
Dec 2, 2022
| } | ||
|
|
||
| private: | ||
| std::map<uint64_t, std::pair<uint64_t, void*>> m_tcs; |
There was a problem hiding this comment.
Suggested change
| std::map<uint64_t, std::pair<uint64_t, void*>> m_tcs; | |
| std::map<uint64_t, std::pair<DB::version_type, void*>> m_tcs; |
LaPeste
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to realm/realm-core#5246
TODO