Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null check for functionArgs in CallResetPasswordFunctionAsync #3106

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

JacobOscarGunnarsson
Copy link
Contributor

Description

passing null as third arg will now throw a more descriptive ArgumentNullException error

Fixes #3011

@papafe
Copy link
Contributor

papafe commented Nov 22, 2022

The code looks nice, you just need to add a Changelog

Copy link
Contributor

@LaPeste LaPeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the entry in the changelog, for me it's good to go.

Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a small test to ensure it works and we don't break it in the future.

@nirinchev nirinchev self-requested a review November 22, 2022 11:16
@papafe
Copy link
Contributor

papafe commented Nov 24, 2022

@nirinchev Given that we don't have tests for any of the null checks for methods in that class, I've suggested @JacobOscarGunnarsson to avoid adding one just for this. It's better if we create a ticket to add them all together

@JacobOscarGunnarsson JacobOscarGunnarsson merged commit 2381d69 into main Nov 24, 2022
@JacobOscarGunnarsson JacobOscarGunnarsson deleted the jg/null_check_call_function branch November 24, 2022 10:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
5 participants