Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue #3175

Merged
merged 1 commit into from Jan 13, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jan 12, 2023

Description

Fixes #3166

TODO

  • Changelog entry

@cla-bot cla-bot bot added the cla: yes label Jan 12, 2023
@nirinchev nirinchev changed the title Update DynamicRealmObjectHelper.TryGetPrimaryKeyValue not to use refl… Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue Jan 12, 2023
@nirinchev nirinchev merged commit e116c31 into main Jan 13, 2023
@nirinchev nirinchev deleted the ni/dynamic-private-id branch January 13, 2023 07:38
papafe added a commit that referenced this pull request Jan 27, 2023
* main:
  Survey ad (#3201)
  Workaround Mono yield bug (#3200)
  Bump docker layer caching action to use node16 (#3193)
  Keypath filtering (#3179)
  Move realm files created by tests to current directory on CI (#2991)
  Fix failing sync tests (#3096)
  Updated example project to MAUI and Source Generators (#3168)
  Fix uwp workflow when running in debug (#3177)
  Deprecate push client (#3176)
  Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue (#3175)
  Keep track of the active transaction and close it on realm close (#3164)
  Add more detailed unsupported type error (#3163)
  Build Xamarin.Android tests in all ABIs (#3165)

# Conflicts:
#	Tests/Realm.Tests/Generated/Realm.SourceGenerator/Realms.SourceGenerator.RealmGenerator/ObjectWithPartitionValue_generated.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicRealmObjectHelper.TryGetPrimaryKeyValue may not work correctly
2 participants