Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11] 6. Remove AppConfiguration.CustomLogger #3238

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[v11] 6. Remove AppConfiguration.CustomLogger #3238

merged 1 commit into from
Feb 24, 2023

Conversation

nirinchev
Copy link
Member

Description

Replaced by Logger.Default.

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Feb 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4193785425

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 81.379%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Logging/Logger.cs 1 53.33%
Totals Coverage Status
Change from base Build 4193603276: -0.05%
Covered Lines: 5868
Relevant Lines: 7073
💛 - Coveralls

@nirinchev nirinchev changed the title [v11] Remove AppConfiguration.CustomLogger [v11] 6. Remove AppConfiguration.CustomLogger Feb 16, 2023
Base automatically changed from ni/v11-sync-configuration to main-v11 February 24, 2023 15:45
@cla-bot cla-bot bot added the cla: yes label Feb 24, 2023
@nirinchev nirinchev merged commit baf415e into main-v11 Feb 24, 2023
@nirinchev nirinchev deleted the ni/v11-appconfig-logger branch February 24, 2023 17:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LaPeste LaPeste Awaiting requested review from LaPeste

Assignees

@nirinchev nirinchev

Labels
Breaking cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @coveralls