Integrate Core logging #3277
Merged
Integrate Core logging #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4574802572
💛 - Coveralls |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Realm/Realm/Handles/AppHandle.cs
Outdated
Comment on lines
180
to
188
| NativeMethods.initialize( | ||
| frameworkName, frameworkName.IntPtrLength(), | ||
| frameworkVersion, frameworkVersion.IntPtrLength(), | ||
| sdkVersion, sdkVersion.IntPtrLength(), | ||
| platformVersion, platformVersion.IntPtrLength(), | ||
| cpuArch, cpuArch.IntPtrLength(), | ||
| deviceName, deviceName.IntPtrLength(), | ||
| deviceVersion, deviceVersion.IntPtrLength(), | ||
| userLogin, taskCallback, stringCallback, logMessage, apiKeysCallback); | ||
| userLogin, taskCallback, stringCallback, apiKeysCallback); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
| @@ -272,6 +275,8 @@ | |||
| NativeMethods.install_callbacks(notifyRealm, getNativeSchema, openRealm, disposeGCHandle, logMessage, notifyObject, notifyDictionary, onMigration, shouldCompact, handleTaskCompletion, onInitialization); | |||
| } | |||
|
|
|||
| public static void SetLogLevel(LogLevel level) => NativeMethods.set_log_level(level); | |||
Check notice
Code scanning / CodeQL
Calls to unmanaged code
| @@ -234,6 +234,9 @@ | |||
| [DllImport(InteropConfig.DLL_NAME, EntryPoint = "shared_realm_refresh_async", CallingConvention = CallingConvention.Cdecl)] | |||
| public static extern bool refresh_async(SharedRealmHandle realm, IntPtr tcs_handle, out NativeException ex); | |||
|
|
|||
| [DllImport(InteropConfig.DLL_NAME, EntryPoint = "shared_realm_set_log_level", CallingConvention = CallingConvention.Cdecl)] | |||
| public static extern bool set_log_level(LogLevel level); | |||
Check notice
Code scanning / CodeQL
Unmanaged code
Closed
| get => _logLevel; | ||
| set | ||
| { | ||
| _logLevel = value; |
Check notice
Code scanning / CodeQL
Static field written by instance method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2910
This will fail on CI due to realm/realm-core#6443, but that is a regression in Core and not something that will affect the feature's implementation.
TODO