Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide collections in mixed from public API #3575

Merged
merged 2 commits into from Apr 17, 2024
Merged

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Apr 16, 2024

No description provided.

Copy link

coveralls-official bot commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8720109810

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 87 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-1.1%) to 79.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/DatabaseTypes/RealmValue.cs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Handles/CollectionHandleBase.cs 2 61.9%
Realm/Realm/Native/PrimitiveValue.cs 4 79.65%
Realm/Realm/DatabaseTypes/RealmDictionary.cs 5 91.36%
Realm/Realm/Handles/ObjectHandle.cs 7 91.71%
Realm/Realm/DatabaseTypes/RealmList.cs 8 85.71%
Realm/Realm/Helpers/CollectionHelpers.cs 9 0.0%
Realm/Realm/Handles/ListHandle.cs 12 88.5%
Realm/Realm/Handles/DictionaryHandle.cs 14 88.89%
Realm/Realm/DatabaseTypes/RealmValue.cs 26 85.71%
Totals Coverage Status
Change from base Build 8709639632: -1.1%
Covered Lines: 6701
Relevant Lines: 8231

💛 - Coveralls

@papafe papafe requested a review from nirinchev April 16, 2024 20:59
@papafe papafe added the no-jira-ticket Skip checking the PR title for Jira reference label Apr 16, 2024
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Consider prefixing out-commented doc comments with "// " instead of "//" and out-commented code with "////" to avoid the warnings from StyleCop SA1005

@papafe
Copy link
Contributor Author

papafe commented Apr 17, 2024

LGTM.

Consider prefixing out-commented doc comments with "// " instead of "//" and out-commented code with "////" to avoid the warnings from StyleCop SA1005

Yes, I just used the VS keyboard shortcut to comment out everything to be fast 😁

@papafe papafe merged commit 7aae358 into main Apr 17, 2024
13 checks passed
@papafe papafe deleted the fp/hide-mixed-collection branch April 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants