Add support for byte[] properties #567
Conversation
|
|
||
| public IEnumerable<object[]> SetAndReplaceWithNullCases() | ||
| { | ||
| yield return new object[] { "NullableCharProperty", '0' }; |
There was a problem hiding this comment.
Looks like copy and paste error - shouldn't these all be null?
There was a problem hiding this comment.
This test first sets the property to a non-null value and asserts the getter returns the value, and then sets the property to null and asserts that the getter returns null.
There was a problem hiding this comment.
OK, yup noted it now.
|
👍 |
fealebenpae
force-pushed
the
yg/binary-columns
branch
from
69468b6
to
50f9f6f
Compare
| if (buffer.Length == 0) | ||
| { | ||
| // see RealmObject.SetByteArrayValue | ||
| NativeQuery.binary_equal(queryHandle, columnIndex, (IntPtr)0x1, IntPtr.Zero); |
There was a problem hiding this comment.
I'm bothered by this 0x1 magic value being repeated as a literal. Does it have significance and, if so, could it be a constant?
There was a problem hiding this comment.
No, it just has to be anything but zero, as long as the length is zero. Seeing as how it's a dummy value I wouldn't bother with a constant.
|
👍 with the added check for empty byte arrays! |
|
👍 |
Implements #510