Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Sync API's with Cocoa #5835

Merged
merged 3 commits into from
Mar 13, 2018
Merged

Align Sync API's with Cocoa #5835

merged 3 commits into from
Mar 13, 2018

Conversation

cmelchior
Copy link
Contributor

@cmelchior cmelchior commented Mar 13, 2018 •
edited
Loading

Align Sync API's with Cocoa.

Reasoning:

“Log in” is a phrasal verb, while “login” is a noun. Given that the method in question performs an action, the verb is the correct choice.

@nhachicha
Copy link
Collaborator

@cmelchior need to update the examples though

@cmelchior
Copy link
Contributor Author

Doh, thanks

@cmelchior cmelchior merged commit 427283d into next-major Mar 13, 2018
@cmelchior cmelchior deleted the cm/align-sync-api branch March 13, 2018 23:01
@Zhuinden
Copy link
Contributor

I've really never seen APIs call it logIn, but I guess it's your call ¯\_(ツ)_/¯

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nhachicha nhachicha nhachicha approved these changes

Assignees

@cmelchior cmelchior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmelchior @nhachicha @Zhuinden