PermissionManager should ignore intermittent errors #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: cmelchior <christian@ilios.dk>
bmunkholm
approved these changes
May 3, 2019
bmunkholm
reviewed
May 3, 2019
nhachicha
approved these changes
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6492
Adds functionality for partly working around https://github.com/realm/realm-java-private/issues/259
Before this PR, the
PermissionManagerheld on to any error reported, even intermittent network errors. This caused it to stop working once such an error was encountered.With this PR, all errors known to be temporary are just ignored, since the end user cannot do anything besides retrying closing/opening the PermissionManager again. Internally we are already retrying sending data which is much more efficient, so no reason to put that burden on the end user.
With this change, only non-recoverable errors should be reported to end users.