Added deprecation

realm · Jun 23, 2023 · a723359 · a723359
1 parent 85eceda
commit a723359
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/integration-tests/tests/src/tests/objects.ts b/integration-tests/tests/src/tests/objects.ts
@@ -974,7 +974,14 @@ describe("Realm.Object", () => {
         });
       });
 
-      const entries = obj.entries();
+      let entries = obj.entries();
+      expect(entries).to.have.length(2);
+      expect(entries).to.have.deep.members([
+        ["pk", "one"],
+        ["value", 1],
+      ]);
+
+      entries = Object.entries(obj);
       expect(entries).to.have.length(2);
       expect(entries).to.have.deep.members([
         ["pk", "one"],
@@ -990,7 +997,11 @@ describe("Realm.Object", () => {
         });
       });
 
-      const keys = obj.keys();
+      let keys = obj.keys();
+      expect(keys).to.have.length(2);
+      expect(keys).to.have.deep.members(["pk", "value"]);
+
+      keys = Object.keys(obj);
       expect(keys).to.have.length(2);
       expect(keys).to.have.deep.members(["pk", "value"]);
     });

diff --git a/packages/realm/src/Object.ts b/packages/realm/src/Object.ts
@@ -274,11 +274,13 @@ export class RealmObject<T = DefaultObject> {
    */
   private declare readonly [KEY_SET]: ReadonlySet<string>;
 
+  /** @deprecated Please use {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys|Object.keys()}  */
   keys(): string[] {
     // copying to prevent caller from modifying the static array.
     return [...this[KEY_ARRAY]];
   }
 
+  /** @deprecated Please use {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries|Object.entries()}*/
   entries(): [string, unknown][] {
     return Object.entries(this);
   }