Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS fixes #3421

Merged
merged 3 commits into from
Nov 25, 2020
Merged

TS fixes #3421

merged 3 commits into from
Nov 25, 2020

Conversation

steffenagger
Copy link
Contributor

@steffenagger steffenagger commented Nov 24, 2020 •
edited
Loading

What, How & Why?

  • Removed lib/index.d.ts (leftover from v10 merge)
  • Updated RealmInsertionModel<T> to ignore function-properties.

☑️ ToDos

  • 📝 Changelog entry

If this PR adds or changes public API's:

  • typescript definitions file is updated

@steffenagger steffenagger marked this pull request as ready for review November 24, 2020 14:34
kraenhansen
kraenhansen approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havn't tested it - but this looks legit 🙂

@steffenagger steffenagger merged commit 015f0ca into master Nov 25, 2020
@steffenagger steffenagger deleted the sa/ts-fixes branch November 25, 2020 11:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kneth kneth kneth approved these changes

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffenagger @kneth @kraenhansen