Update RN install test to pass the --new-architecture runtime option
#5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a test run showing that enabling new architecture for |
kneth
approved these changes
May 31, 2023
|
I have approved the PR as we want to test against the new architecture. The question is why we see |
|
That's probably just a symptom of the native .so not loading correctly. |
|
I approve in retrospect |
papafe
added a commit
that referenced
this pull request
Jun 7, 2023
* main: Fix User.callFunction JSDoc to match the v11+ API (#5768) Add Flexible Sync subscribe/unsubscribe APIs (#5772) Fix warning for deprecated namespace setting method in Android (#5862) Update install-test-react-native.yml (#5848) Update package-unit-tests.yml to add ccache and ninja (#5837) Enable cleartext traffic in android test app to make tests work in release builds # Conflicts: # CHANGELOG.md
papafe
added a commit
that referenced
this pull request
Jun 7, 2023
* fp/update-core-13.13: Corrected changelog Updated changelog Fix User.callFunction JSDoc to match the v11+ API (#5768) Add Flexible Sync subscribe/unsubscribe APIs (#5772) Fix warning for deprecated namespace setting method in Android (#5862) Update install-test-react-native.yml (#5848) Update package-unit-tests.yml to add ccache and ninja (#5837) Enable cleartext traffic in android test app to make tests work in release builds Removed unused Updated changelog # Conflicts: # packages/realm/bindgen/vendor/realm-core # packages/realm/src/index.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
It seems we didn't pass the new architecture matrix variable correctly to the CLI when initialising the install test app.