Run tests from ReactNative #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a CommonJS module loader that is used by XCTestCase subclass to load and run the tests.
Needs this to link to GCDWebServer.
* sk-react-framework: (27 commits) Change RealmReact to be a dynamic framework finish Array to List rename RJSArray -> RJSList move property getters to object store code move List class to its own file ObjectArray -> List Add Notification constructor and destructor Small improvement to notifications test RJSException no longer requires JS strings Protect realm and callback from GC in addNotification Add comments pr fixes minimal tests for migrations Check for NaN inside RJSValidatedValueToNumber allow running all tests at the same path by invalidating all cached realm paths between test runs Native methods should convert to numbers/bools Out of bounds getters for Results return undefined Out of bounds list item getters return undefined Consolidate code that verifies array index bounds Add list item setters in JS ...
This handles clearing out all of the test files between each test case.
|
|
||
| 'use strict'; | ||
|
|
||
| exports.ArrayTests = require('./ArrayTests'); |
There was a problem hiding this comment.
In one of the other files, we changed the style to
exports = {
ArrayTests: require('./ArrayTests'),
...
};
There was a problem hiding this comment.
I don't think it's worth doing that here but I do some other manipulations of exports in a future commit.
An exception was thrown when parsing the JSON when only a string was passed. This is better and no longer uses the Objective-C API for converting the dictionary to a JSValue.
Error responses were not having this set, which obscured the true error from the client.
The deleteTestFiles() function is now added to the Realm object, so that it's easy for the RPC module to handle this as well. We can only do this in testing environments in the future.
The test structure is now provided by a JS API, that is used by all things that run tests. Also, the tests can be run manually by tapping a button in the ReactTests app.
This also appears to fix crashes when running ReactTests with Chrome debugging enabled! The crash when tests failed was due to JavaScriptCore trying to create a backtrace with the native call stack.
|
Lets review this and git it merged! |
|
I'm happy with this at this point 👍 |
|
The new tests are now successfully running on ci. |
alazier
pushed a commit
that referenced
this pull request
May 5, 2016
Move cmake_minimum_required() to the correct place
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.