RJS-2739: Upgrade to Realm Core v14.1.0 #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Feb 28, 2024
Comment on lines
+754
to
+768
|
|
||
| itNormalizes( | ||
| { | ||
| type: "list", | ||
| objectType: "string", | ||
| indexed: true, | ||
| }, | ||
| { | ||
| type: "list", | ||
| objectType: "string", | ||
| indexed: true, | ||
| optional: false, | ||
| }, | ||
| { isPrimaryKey: false }, | ||
| ); |
There was a problem hiding this comment.
Seems fine, but it also seems unrelated to the upgrade.
There was a problem hiding this comment.
I added this because the upgrade also included being able to index list of strings. So this tests that the parser also allows this.
There was a problem hiding this comment.
It is testing an enhancement mentioned in the changelog.
kneth
force-pushed
the
kneth/realm-core-14.0.1
branch
from
67dfe08
to
f560e0f
Compare
kneth
force-pushed
the
kneth/realm-core-14.0.1
branch
from
2ff005c
to
33146b3
Compare
* Update 'setLogLevel()'. * Update 'setLogger()'. * Fix 'at_since' doc tag. * Integrate feedback Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com> * Assume logger with options for remaining cases. * Update TS docs for 'LogOptions'. --------- Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
kneth
force-pushed
the
kneth/realm-core-14.0.1
branch
from
e65a1e6
to
eb00687
Compare
kraenhansen
reviewed
Mar 5, 2024
kraenhansen
reviewed
Mar 5, 2024
packages/realm/src/Logger.ts
Outdated
Comment on lines
77
to
144
| export enum LogCategory { | ||
| /** | ||
| * Include logs from all categories. Subcategories are {@link LogCategory.Storage}, | ||
| * {@link LogCategory.Sync}, {@link LogCategory.App}, and {@link LogCategory.SDK}. | ||
| */ | ||
| Realm = "Realm", | ||
| /** | ||
| * Log database mutations and query operations. | ||
| * Subcategories are {@link LogCategory.Transaction}, {@link LogCategory.Object}, | ||
| * {@link LogCategory.Query}, and {@link LogCategory.Notification}. | ||
| */ | ||
| Storage = "Realm.Storage", | ||
| /** | ||
| * Log when creating, advancing, and committing transactions. | ||
| */ | ||
| Transaction = "Realm.Storage.Transaction", | ||
| /** | ||
| * Log query operations. | ||
| */ | ||
| Query = "Realm.Storage.Query", | ||
| /** | ||
| * Log database mutations. | ||
| */ | ||
| Object = "Realm.Storage.Object", | ||
| /** | ||
| * Log notifications of changes to the database. | ||
| */ | ||
| Notification = "Realm.Storage.Notification", | ||
| /** | ||
| * Log activity related to Atlas Device Sync. | ||
| * Subcategories are {@link LogCategory.Client} and {@link LogCategory.Server}. | ||
| */ | ||
| Sync = "Realm.Sync", | ||
| /** | ||
| * Log activity related to Atlas Device Sync client operations. | ||
| * Subcategories are {@link LogCategory.Session}, {@link LogCategory.Changeset}, | ||
| * {@link LogCategory.Network}, and {@link LogCategory.Reset}. | ||
| */ | ||
| Client = "Realm.Sync.Client", | ||
| /** | ||
| * Log connection level activity. | ||
| */ | ||
| Session = "Realm.Sync.Client.Session", | ||
| /** | ||
| * Log when receiving, uploading, and integrating changesets. | ||
| */ | ||
| Changeset = "Realm.Sync.Client.Changeset", | ||
| /** | ||
| * Log low level network activity. | ||
| */ | ||
| Network = "Realm.Sync.Client.Network", | ||
| /** | ||
| * Log client reset operations. | ||
| */ | ||
| Reset = "Realm.Sync.Client.Reset", | ||
| /** | ||
| * Log activity related to Atlas Device Sync server operations. | ||
| */ | ||
| Server = "Realm.Sync.Server", | ||
| /** | ||
| * Log activity at the Atlas App level. | ||
| */ | ||
| App = "Realm.App", | ||
| /** | ||
| * Log activity at the SDK level. | ||
| */ | ||
| SDK = "Realm.SDK", | ||
| } |
There was a problem hiding this comment.
I still feel using an enum with the leaf name as key isn't the best API design and would rather that we used a string union here. The main reason being that it's possible for Core to introduce a category that we can't unambiguously express to our users.
I.e. what do we do if core introduces a "Realm.Sync.Server.Changeset" or a "Realm.App.Network" category?
elle-j
reviewed
Mar 5, 2024
kraenhansen
force-pushed
the
kneth/realm-core-14.0.1
branch
from
16e2b2b
to
c3ffbe6
Compare
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
kneth
changed the title
* Suggesting array of categories and string union for LogCategory * Moved documentation onto the type * Moved setLogger using LoggerCallback2 up * Exporting "LogEntry" type * Lint fixing tests
kraenhansen
approved these changes
Mar 6, 2024
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
* RJS-2739: Upgrade to Realm Core v14.1.0 --------- Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com> Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6499
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary