Suggesting array of categories and string union for LogCategory #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
It gives good intellisense 👌 And since the addition of duplicate names does not seem unlikely, it could be good to incorporate this change to prevent future breaking changes. It didn't look like the LOG_CATEGORIES array was publicly exported, which I think is probably important (to not have exported) since users may start relying on the indices which would also break with added categories.
kraenhansen
commented
Mar 5, 2024
| * }); | ||
| */ | ||
| static setLogger(loggerCallback: LoggerCallback1): void; | ||
| static setLogger(loggerCallback: LoggerCallback2): void; |
There was a problem hiding this comment.
I'm moving this up to improve DX by hitting this as the default overload.
There was a problem hiding this comment.
But that could be considered breaking 😬
kneth
approved these changes
Mar 6, 2024
kraenhansen
force-pushed
the
kh/realm-core-14.0.1-feedback-2
branch
from
b000df9
to
5410e91
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This PR is a suggestion to address this comment: #6512 (comment)